Skip to content

Add DeleteFiles snapshot update API#13

Open
manuzhang wants to merge 1 commit into
mainfrom
codex/add-deletefiles-api
Open

Add DeleteFiles snapshot update API#13
manuzhang wants to merge 1 commit into
mainfrom
codex/add-deletefiles-api

Conversation

@manuzhang

@manuzhang manuzhang commented May 21, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Add the C++ equivalent of Iceberg Java's DeleteFiles API now that MergingSnapshotUpdate is available.

Description

  • Add iceberg::DeleteFiles backed by MergingSnapshotUpdate with DeleteFile(path), DeleteFile(DataFile), DeleteFromRowFilter, CaseSensitive, and ValidateFilesExist.
  • Expose NewDeleteFiles from Table and Transaction.
  • Add CMake/Meson wiring and focused DeleteFiles tests.

Testing

  • cmake --build build --target table_update_test
  • ./build/src/iceberg/test/table_update_test '--gtest_filter=DeleteFilesTest.*'
  • ./build/src/iceberg/test/table_update_test

@manuzhang

Copy link
Copy Markdown
Owner Author

@chatgpt-codex-connector

Copy link
Copy Markdown

Summary

  • Added API documentation above table::DeleteFiles to explicitly align C++ path-matching behavior with the Java DeleteFiles semantics referenced in the PR comment (exact metadata path matching; differently-normalized equivalent URIs are not treated as matches).
  • Committed the change on branch work with commit 9f6b774ca53e412ade9d0a54e57aebea44609b67.
  • Created a follow-up PR message via make_pr with title: “docs: align DeleteFiles semantics with Iceberg Java API reference”.

Testing

  • git status --short
  • git add src/iceberg/table_update.h && git commit -m "Clarify DeleteFiles path matching semantics"
  • nl -ba src/iceberg/table_update.h | sed -n '606,628p'

View task →

@manuzhang manuzhang force-pushed the codex/add-deletefiles-api branch from 00cb9fc to ff57d7a Compare June 8, 2026 04:23
@manuzhang manuzhang changed the title Add DeleteFiles table update API Add DeleteFiles snapshot update API Jun 8, 2026
@manuzhang

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@manuzhang manuzhang force-pushed the codex/add-deletefiles-api branch from c144cda to 5665d37 Compare June 8, 2026 08:04
Extend MergingSnapshotProducer with a DeleteFiles API and expose it through table and transaction update flows.

Add DeleteFiles coverage for path matching, case-insensitive row filters, empty delete commits, and strict-projection partial-match rejection.

Co-authored-by: Codex <codex@openai.com>
@manuzhang manuzhang force-pushed the codex/add-deletefiles-api branch from 5665d37 to 87a39b2 Compare June 8, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant