Merged
Conversation
Collaborator
Author
|
@erz9engel I would wait for unit tests from #32 because it will be better to validate a new logic |
erz9engel
reviewed
Mar 25, 2026
erz9engel
reviewed
Mar 25, 2026
erz9engel
reviewed
Mar 25, 2026
…en delegate multipart
Stop creating dynamic proxy classes via 'type()' and instead return standard 'Endpoint' instances. This improves runtime performance, traceback readability, and static typing support.
this user is not authorized
erz9engel
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links:
Actions:
Core SDK & Client:
Configclass to use a deterministic, data-driven routing approach withEXACT_ROUTESandPREFIX_ROUTES.domains_handlerto properly construct hierarchical and nested URLs (e.g., credentials, IPs, webhooks).EndpointandAsyncEndpointto capture detailed request URLs and API errors.httpxDeprecationWarninginAsyncEndpointby routing serialized string/byte payloads to thecontent=parameter instead ofdata=.Integration Tests:
DomainTeststo use the-traditionalflag, ensuring valid PKCS1 format for DKIM tests.test_selectortotest-selector.AttributeErrorinAsyncKeysTestsby correctly referencingself.domaininstead of the uninitializedself.test_domain.@pytest.mark.xfail(reason=...)(e.g.,test_verify_domain,test_get_sending_queues,test_update_account_tag,test_delete_key).Unit Tests:
tests/unit/test_routes.pyto enforce strict schemas for routing dictionaries and prevent overlapping keys.test_config.pyto validate the new fallback and alias mapping logic.TypeErrorintest_client.pycaused by comparingMagicMockobjects to integer HTTP status codes.FileNotFoundErrorintest_async_client.pyby safely monkeypatching the brokenSSL_CERT_FILEenvironment variable duringhttpx.AsyncClientinitialization.Linting & Formatting:
refurbmodernizations: replacetry/except: passwithcontextlib.suppress, optimize equality checks with theinoperator, and utilize implicit truthiness for collection checks.pyrightstrict typing errors: eliminate blanket# type: ignorecomments, explicitly declare| Noneunions, and implement type narrowing for object attributes to preventOptionalMemberAccesserrors.CI & Repository Management:
.github/dependabot.ymlto group minor and patch updates and set an open PR limit..github/workflows/commit_checks.yamlto install test dependencies and execute unit tests during CI runs.