Repository navigation
Add Minecraft 26.3 NMS support - #165
Merged
Merged
Conversation
Add codex-nms-v26_3 module built against Spigot 26.3, register it in codex-core, and map 26.3 servers to it in VersionManager and Version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015SJWkKAESR9PJNPooW9ovC
AxeItem no longer exists in 26.3, so identify axes via Tag.ITEMS_AXES. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015SJWkKAESR9PJNPooW9ovC
codex-nms pinned codex-parent/codex-api 1.2.0-R0.4-SNAPSHOT, whose dependency on dev.lone:api-itemsadder:4.0.10 no longer resolves from any configured repository. Bump to 1.2.0-R0.7-SNAPSHOT and resolve the parent from the reactor via relativePath. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015SJWkKAESR9PJNPooW9ovC
NMS modules are deployed independently, so codex-nms must reference published artifacts rather than the unreleased dev version or the in-repo parent. R0.6 is the latest published snapshot and no longer pulls the unresolvable dev.lone:api-itemsadder:4.0.10. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015SJWkKAESR9PJNPooW9ovC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex-nms-v26_3module (built againstspigot/spigot-api26.3-R0.1-SNAPSHOT), modeled on the 26.2 module, and registers it incodex-nms/pom.xmlandcodex-core/pom.xml.VersionManagermaps26.3→v26_3;VersiongainsV26_R2for26.3/26.3-R0.1-SNAPSHOT. 26.1.2 and 26.2 keep usingv26_2.net.minecraft.world.item.AxeItem, soNMSImpl.isWeaponnow detects axes viaTag.ITEMS_AXES.VersionManagerTestcase for26.3.codex-nmsversion drift: it pinnedcodex-parent/codex-api1.2.0-R0.4-SNAPSHOT, whose dependencydev.lone:api-itemsadder:4.0.10no longer resolves. Now pinned to1.2.0-R0.6-SNAPSHOT, the latest published snapshot (usesitemsadder-api:4.0.17). The parent is still resolved from the repo (<relativePath/>) so the NMS modules can be deployed independently.Testing
mvn -U install -f codex-nms/pom.xml -pl codex-nms-v26_3 -am: BUILD SUCCESS, resolvingcodex-parentandcodex-api1.2.0-R0.6-SNAPSHOTfrom repo.travja.dev.codex-apifrom the root reactor: all 9 tests pass, including bothVersionManagerTestcases.Notes
[ci skip] Update dev versionbump doesn't touchcodex-nms/pom.xml, which is intentional now that it pins published versions — bump it manually when the NMS modules need a newercodex-api.pom-dev.xml) resolvecodex-nms-v26_3from the snapshot repo, so they'll fail until the NMS modules are published — same situation as the 26.2 upgrade.🤖 Generated with Claude Code
https://claude.ai/code/session_015SJWkKAESR9PJNPooW9ovC