Completely fake out TLS for testing - #9640
Merged
Merged
Conversation
This covers the happy path of OkHttp + MockWebServer with HTTPS. This doesn't actually perform anything cryptographic; certificates and protocols and things are transmitted in-memory rather than over the wire. This replaces the Okio.inMemorySocketPair() after the fake TLS handshake; that way there's no risk of data leaking from the pre-encrypted session to the post-encrypted session. The useful capability this unlocks is testing TLS scenarios like ECH retries, before we have a server-side TLS stack that can support them.
yschimke
reviewed
Aug 8, 2026
|
|
||
| val (clientSocket, serverSocket) = inMemorySocketPair(maxBufferSize = 1024 * 1024) | ||
|
|
||
| return Handshaker.Result( |
Collaborator
There was a problem hiding this comment.
Fun to see. I still hope we can kick over Tls Socket code to those suckers who work on okio. :)
This could be a nice fake over there.
Collaborator
Author
There was a problem hiding this comment.
I think your SocketAdapter abstraction is really the thing we need around these parts. A good enough SocketAdapter API might make it so we can confirm Conscrypt conforms to our Socket expectations, without actually running all the tests against it.
Collaborator
Author
There was a problem hiding this comment.
(And similarly for all other TLS things)
yschimke
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers the happy path of OkHttp + MockWebServer with HTTPS.
This doesn't actually perform anything cryptographic; certificates and protocols and things are transmitted in-memory rather than over the wire.
This replaces the Okio.inMemorySocketPair() after the fake TLS handshake; that way there's no risk of data leaking from the pre-encrypted session to the post-encrypted session.
The useful capability this unlocks is testing TLS scenarios like ECH retries, before we have a server-side TLS stack that can support them.