Add overdue tests for FakeNetwork - #9638
Merged
Merged
Conversation
The test that uses real OkHttp is good to confirm it works, but it isn't useful for debugging problems with FakeNetwork.
yschimke
reviewed
Aug 7, 2026
| @JvmField | ||
| val clientTestRule = OkHttpClientTestRule() | ||
|
|
||
| val taskRunner = TaskRunner.INSTANCE |
Collaborator
There was a problem hiding this comment.
It's good you can use either, but would you typically use TaskFaker to be 100% deterministic?
Collaborator
Author
There was a problem hiding this comment.
YES! I need to make TaskFaker able to fake out wait + notify.
yschimke
approved these changes
Aug 7, 2026
swankjesse
force-pushed
the
jwilson.0807.network_tests
branch
from
August 7, 2026 23:48
66a4756 to
6c187a5
Compare
swankjesse
commented
Aug 7, 2026
| } | ||
| } | ||
|
|
||
| internal class SocketSource( |
Collaborator
Author
There was a problem hiding this comment.
FYI the new tests showed that there’s a race closing sockets which caused some tests to flake.
The fix was straightforward-enough . . . the source & sink offered by FakeSocket needs to track its own closed state. Previously I was relying on Socket.cancel() to do that, but it closes the peer stream asynchronously and we don’t want that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test that uses real OkHttp is good to confirm it works, but it isn't useful for debugging problems with FakeNetwork.