Start @StartStop MockWebServer for @Nested JUnit 5 tests - #9634
Open
HDPark95 wants to merge 1 commit into
Open
Conversation
StartStopExtension.beforeEach resolved instance fields from context.testInstance (the innermost @nested instance) and context.requiredTestClass (the nested class), so a @startstop MockWebServer field declared on an enclosing class was never started. A nested test that touched the server failed with "call start() first". Walk context.requiredTestInstances.allInstances instead and start the annotated fields on every instance in the hierarchy. Behavior is unchanged for non-nested tests, where allInstances is the single test instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9546.
A
@StartStop MockWebServerfield declared on an outer class is never started when the test runs inside a@Nestedinner class, so a nested test that uses the server fails withIllegalStateException: call start() first.StartStopExtension.beforeEachresolved instance fields fromcontext.testInstance(the innermost@Nestedinstance) andcontext.requiredTestClass(the nested class). A@StartStopfield on an enclosing class is on neither, so it was never found or started. Top-level tests were unaffected because the test instance and its declaring class line up.The fix walks
context.requiredTestInstances.allInstances, which returns every instance in the enclosing hierarchy, and starts the annotated fields on each. Behavior is unchanged for non-nested tests, whereallInstancesis the single test instance.Added
NestedStartStopTest, which declares a@StartStopserver on the outer class and one on a@Nestedinner class and asserts both are started from a nested test. It fails before the change and passes after.