[rtl] Remove ztop related dead code - #2504
Merged
Merged
Conversation
This was used to indicate the revocation memory location, which we implement differently Signed-off-by: Samuel Riedel <sriedel@lowrisc.org>
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Removes obsolete ZTOP capability support from CHERIoT RTL and tracing.
Changes:
- Removes ZTOPC constants and trace naming.
- Removes obsolete execution-unit ports, logic, and core wiring.
- Preserves CSR address 27 as reserved/illegal.
File summaries
| File | Description |
|---|---|
rtl/ibex_tracer.sv |
Removes obsolete ZTOP tracing name. |
rtl/ibex_core.sv |
Removes obsolete ZTOP connections. |
rtl/ibex_cheriot_pkg.sv |
Removes the ZTOPC CSR constant. |
rtl/ibex_cheriot_ex.sv |
Removes ZTOP inputs and execution handling. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was used to indicate the revocation memory location, which we implement differently