refactor: remove dead code and dedupe redundant utilities#1230
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe pull request removes obsolete comparator, sudo-password, tmux, resource, and localization APIs. It centralizes shell quoting through a shared utility, updates tmux exports, changes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
l10n.xxxcall sites) across allapp_*.arbfiles and regenerate l10n.TmuxSession.setChoice/buildReconnectCommand/buildAutoCommand/choiceNotifier/lastSessionName, and unuseddisplayNamegetters onTmuxSessionInfo/TmuxWindowInfo.Defaults.primaryColor,Miscs.multiBlankReg,Miscs.jsonEncoder,Urls.cdnBase(and their now-unuseddart:ui/dart:convertimports).ChainComparator.comparing/thenCompareByReversed/reversed()andSudoPassword.hasOverride.shellSingleQuote:container.dartno longer carries a copy; it forwards to the canonicalcore/utils/shell_quote.dartimplementation (a single-line delegator is required because part files cannot reference imported top-level names inside extension method bodies).EquatableMixinwithEquatablemixin indisk.dart; complete thetmux_export.dartbarrel export withtmux_window_info.dart.Verification
dart analyze libreports no issues.flutter gen-l10nregenerated.flutter testpasses (331 tests).Notes
libL10nnames but are still referenced were intentionally left in place.Summary by CodeRabbit