Skip to content

no_std support#57

Merged
ljedrz merged 7 commits into
ljedrz:feat/4.0from
portal-co:pr/no_std
May 16, 2025
Merged

no_std support#57
ljedrz merged 7 commits into
ljedrz:feat/4.0from
portal-co:pr/no_std

Conversation

@gkgoat1

@gkgoat1 gkgoat1 commented Mar 23, 2025

Copy link
Copy Markdown

Note that this raises the MSRV (if there is one). maybe version 4?

@ljedrz

ljedrz commented Mar 24, 2025

Copy link
Copy Markdown
Owner

Thanks! The MSRV is not specified, but I'm ok with setting one; would you like to include a version bump (to 4.0.0), and perhaps also apply the 2024 edition (which requires an MSRV of 1.85)?

And please feel free to also look at #56 in case you see potential for any API changes.

@gkgoat1 gkgoat1 changed the base branch from master to feat/4.0 March 25, 2025 10:39
@gkgoat1

gkgoat1 commented Mar 25, 2025

Copy link
Copy Markdown
Author

Thanks! The MSRV is not specified, but I'm ok with setting one; would you like to include a version bump (to 4.0.0), and perhaps also apply the 2024 edition (which requires an MSRV of 1.85)?

I just changed the base branch to the 4.0 branch, so this can be merged without compatibility issues.

And please feel free to also look at #56 in case you see potential for any API changes.

@gkgoat1

gkgoat1 commented Apr 18, 2025

Copy link
Copy Markdown
Author

@ljedrz I just applied the 2024 edition within my pr. Is it ready to merge into the 4.0 staging branch?

@ljedrz

ljedrz commented Apr 18, 2025

Copy link
Copy Markdown
Owner

It seems that bumping the edition requires some further changes; once the CI is green, I'm happy to merge into 4.0.

@gkgoat1

gkgoat1 commented May 15, 2025

Copy link
Copy Markdown
Author

@ljedrz Are you still looking into this? The CI currently requires approval.

@ljedrz

ljedrz commented May 15, 2025

Copy link
Copy Markdown
Owner

Apologies, I missed the notification.

@ljedrz ljedrz left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ljedrz ljedrz merged commit cf8903b into ljedrz:feat/4.0 May 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants