handle pinned regions with API requests#953
Open
davidzhao wants to merge 1 commit into
Open
Conversation
the feature is not enabled yet on the server-side
cnderrauber
approved these changes
Jul 20, 2026
cnderrauber
approved these changes
Jul 20, 2026
cnderrauber
reviewed
Jul 20, 2026
| // A non-cloud host has nowhere to redirect: a single attempt. A cloud host | ||
| // always goes through the failover loop, even when general failover is off, so a | ||
| // 451 region-pin rejection can still be redirected. | ||
| if maxAttempts == 1 && !cloud { |
Contributor
There was a problem hiding this comment.
Above comment said "attempts() > 1 only when failover is enabled for a cloud host.", Can we use if !cloud here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the feature is not enabled yet on the server-side