Skip to content

handle pinned regions with API requests#953

Open
davidzhao wants to merge 1 commit into
mainfrom
dz/handle-region-pin
Open

handle pinned regions with API requests#953
davidzhao wants to merge 1 commit into
mainfrom
dz/handle-region-pin

Conversation

@davidzhao

Copy link
Copy Markdown
Member

the feature is not enabled yet on the server-side

the feature is not enabled yet on the server-side

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Comment thread failover.go
// A non-cloud host has nowhere to redirect: a single attempt. A cloud host
// always goes through the failover loop, even when general failover is off, so a
// 451 region-pin rejection can still be redirected.
if maxAttempts == 1 && !cloud {

@cnderrauber cnderrauber Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above comment said "attempts() > 1 only when failover is enabled for a cloud host.", Can we use if !cloud here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants