Open
Conversation
This makes setting up e2ee much more straightforward.
…ble again Adding this new state in #1309 seems to have made session.start no longer stable, which broke all the examples...
🦋 Changeset detectedLatest commit: 06630ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
size-limit report 📦
|
Contributor
Author
|
@lukasIO Given your updates, would you say this is now in a mergable state? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to pass an
encryptionparameter touseSessionwhich allows for an easier path for configuring e2ee on a room.I have updated
examples/nextjs/pages/e2ee.tsxto use this newencryptionparameter.Additionally, while fixing this, I discovered a small bug introduced as part of #1309 -
session.startwas no longer a stable reference, so unfortunately because of this most of the examples were stuck in an infinite connect / disconnect loop 😬 . I converted the associated state value into a ref (which looks to be safe in this case) and now makessession.startreference stable, making the examples all work again.Todo