Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/native_build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

- name: set up JDK 17
uses: actions/setup-java@1bcf9fb12cf4aa7d266a90ae39939e61372fe520 # v5.4.0
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Android CI build may break because the requested Java flavor is retired in the new tool version

The Android job still asks for the retired "adopt" Java flavor (distribution: 'adopt' at .github/workflows/native_build.yaml:22) while upgrading to a version that deprecates it, so the Android compile job can start warning or failing outright.
Impact: The Android compile check in CI may stop working, blocking pull requests.

Deprecated Adopt distribution in setup-java v5.7.0

The release notes for the bumped version explicitly include "Deprecate legacy Adopt distributions in v5" (actions/setup-java#1186). The pinned SHA b6effb05e454b25005698d916606bdc6ffcbf961 is that commit. The workflow at .github/workflows/native_build.yaml:19-22 continues to pass distribution: 'adopt', which AdoptOpenJDK no longer publishes (superseded by Eclipse Temurin). Switching to temurin keeps the same JDK 17 build with a maintained distribution.

Prompt for agents
The Android job in .github/workflows/native_build.yaml sets up JDK 17 with distribution: 'adopt'. The setup-java bump to v5.7.0 deprecates legacy Adopt distributions, so this input may emit deprecation warnings now and stop resolving in a future release. Consider migrating the distribution to 'temurin' (the successor to AdoptOpenJDK) while keeping java-version '17', and verify the Gradle assembleDebug step still passes.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

with:
java-version: '17'
distribution: 'adopt'
Expand Down
Loading