Security: Verbose Logging of Sensitive Audio Data#438
Conversation
The `AudioSinkRenderer` logs the base64 encoded audio data, its length, and other metadata using `NSLog`. This verbose logging can expose sensitive audio stream data in the device's console logs, which could be intercepted by other processes or during debugging sessions. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
|
|
davidliu
left a comment
There was a problem hiding this comment.
Could've sworn this was cleaned up a while ago, must have slipped through somewhere. Thanks for the PR!
|
Also, can you sign the CLA? It's a requirement for merging any PR. |
|
Sure, I'll sign the CLA right away. Thanks for the reminder, and let me know if there's anything else needed before this can be merged. |
5 similar comments
|
Sure, I'll sign the CLA right away. Thanks for the reminder, and let me know if there's anything else needed before this can be merged. |
|
Sure, I'll sign the CLA right away. Thanks for the reminder, and let me know if there's anything else needed before this can be merged. |
|
Sure, I'll sign the CLA right away. Thanks for the reminder, and let me know if there's anything else needed before this can be merged. |
|
Sure, I'll sign the CLA right away. Thanks for the reminder, and let me know if there's anything else needed before this can be merged. |
|
Sure, I'll sign the CLA right away. Thanks for the reminder, and let me know if there's anything else needed before this can be merged. |
Summary
Security: Verbose Logging of Sensitive Audio Data
Problem
Severity:
Medium| File:ios/audio/AudioSinkRenderer.swift:L17The
AudioSinkRendererlogs the base64 encoded audio data, its length, and other metadata usingNSLog. This verbose logging can expose sensitive audio stream data in the device's console logs, which could be intercepted by other processes or during debugging sessions.Solution
Remove the
NSLogstatements that print the audio data payload and its length. If logging is necessary for debugging, use a conditional debug flag and avoid logging raw data payloads.Changes
ios/audio/AudioSinkRenderer.swift(modified)