Skip to content

Security: Verbose Logging of Sensitive Audio Data#438

Open
tomaioo wants to merge 1 commit into
livekit:mainfrom
tomaioo:fix/security/verbose-logging-of-sensitive-audio-data
Open

Security: Verbose Logging of Sensitive Audio Data#438
tomaioo wants to merge 1 commit into
livekit:mainfrom
tomaioo:fix/security/verbose-logging-of-sensitive-audio-data

Conversation

@tomaioo

@tomaioo tomaioo commented Jul 19, 2026

Copy link
Copy Markdown

Summary

Security: Verbose Logging of Sensitive Audio Data

Problem

Severity: Medium | File: ios/audio/AudioSinkRenderer.swift:L17

The AudioSinkRenderer logs the base64 encoded audio data, its length, and other metadata using NSLog. This verbose logging can expose sensitive audio stream data in the device's console logs, which could be intercepted by other processes or during debugging sessions.

Solution

Remove the NSLog statements that print the audio data payload and its length. If logging is necessary for debugging, use a conditional debug flag and avoid logging raw data payloads.

Changes

  • ios/audio/AudioSinkRenderer.swift (modified)

The `AudioSinkRenderer` logs the base64 encoded audio data, its length, and other metadata using `NSLog`. This verbose logging can expose sensitive audio stream data in the device's console logs, which could be intercepted by other processes or during debugging sessions.

Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Jul 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3406bb0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@davidliu davidliu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could've sworn this was cleaned up a while ago, must have slipped through somewhere. Thanks for the PR!

@davidliu

Copy link
Copy Markdown
Contributor

Also, can you sign the CLA? It's a requirement for merging any PR.

@tomaioo

tomaioo commented Jul 21, 2026

Copy link
Copy Markdown
Author

Sure, I'll sign the CLA right away. Thanks for the reminder, and let me know if there's anything else needed before this can be merged.

5 similar comments
@tomaioo

tomaioo commented Jul 21, 2026

Copy link
Copy Markdown
Author

Sure, I'll sign the CLA right away. Thanks for the reminder, and let me know if there's anything else needed before this can be merged.

@tomaioo

tomaioo commented Jul 22, 2026

Copy link
Copy Markdown
Author

Sure, I'll sign the CLA right away. Thanks for the reminder, and let me know if there's anything else needed before this can be merged.

@tomaioo

tomaioo commented Jul 22, 2026

Copy link
Copy Markdown
Author

Sure, I'll sign the CLA right away. Thanks for the reminder, and let me know if there's anything else needed before this can be merged.

@tomaioo

tomaioo commented Jul 22, 2026

Copy link
Copy Markdown
Author

Sure, I'll sign the CLA right away. Thanks for the reminder, and let me know if there's anything else needed before this can be merged.

@tomaioo

tomaioo commented Jul 22, 2026

Copy link
Copy Markdown
Author

Sure, I'll sign the CLA right away. Thanks for the reminder, and let me know if there's anything else needed before this can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants