Skip to content

fix(wm): sync desktop state when clicking show-desktop on taskbar#1168

Open
gugullll wants to merge 1 commit into
linuxdeepin:masterfrom
gugullll:fix/b1
Open

fix(wm): sync desktop state when clicking show-desktop on taskbar#1168
gugullll wants to merge 1 commit into
linuxdeepin:masterfrom
gugullll:fix/b1

Conversation

@gugullll

Copy link
Copy Markdown
Contributor

After opening multiple windows, clicking the "Show Desktop" plugin on the right side of the taskbar does not sync the desktop state correctly. Connect requestShowDesktop signal to setDesktopState to ensure the desktop state updates on toggle.

打开多个窗口后,点击任务栏右侧"显示桌面"插件时桌面状态未正确
同步。将requestShowDesktop信号连接到setDesktopState,确保切换时
桌面状态正确更新。

Log: 修复点击任务栏显示桌面后桌面状态未同步的问题
PMS: BUG-370639
Influence: 修复后点击任务栏"显示桌面"插件时桌面状态能正确同步更新。

After opening multiple windows, clicking the "Show Desktop" plugin
on the right side of the taskbar does not sync the desktop state
correctly. Connect requestShowDesktop signal to setDesktopState to
ensure the desktop state updates on toggle.

打开多个窗口后,点击任务栏右侧"显示桌面"插件时桌面状态未正确
同步。将requestShowDesktop信号连接到setDesktopState,确保切换时
桌面状态正确更新。

Log: 修复点击任务栏显示桌面后桌面状态未同步的问题
PMS: BUG-370639
Influence: 修复后点击任务栏"显示桌面"插件时桌面状态能正确同步更新。

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @gugullll, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gugullll

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown

Hi @gugullll. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wineee
wineee marked this pull request as draft July 17, 2026 09:46
@wineee
wineee marked this pull request as ready for review July 17, 2026 09:46
@@ -58,6 +58,10 @@ WindowManagementInterfaceV1::WindowManagementInterfaceV1(QObject *parent)
, d(new WindowManagementInterfaceV1Private(this))
{
qRegisterMetaType<DesktopState>("DesktopState");

connect(this, &WindowManagementInterfaceV1::requestShowDesktop, this, [this](uint32_t state) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接删除 requestShowDesktop 这个信号,发信号处调用 setDesktopState

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants