feat(waylib): add sgrenderer damage tracking and vendored wlroots renderer#1136
Draft
Groveer wants to merge 1 commit into
Draft
feat(waylib): add sgrenderer damage tracking and vendored wlroots renderer#1136Groveer wants to merge 1 commit into
Groveer wants to merge 1 commit into
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Groveer The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
zzxyb
requested changes
Jul 13, 2026
zzxyb
left a comment
zzxyb
left a comment
Collaborator
There was a problem hiding this comment.
建议参考wlroots,然后以C++风格去写，这样可以避免引入wlroots很多功能结构和文件
| @@ -0,0 +1,44 @@ | |||
| // SPDX-FileCopyrightText: 2017-2023 wlroots contributors | |||
Collaborator
There was a problem hiding this comment.
allocator不需要copy,可以直接使用wlroots,或者自己扩展实现
| #include <wlr/render/interface.h> | ||
| #include <wlr/render/pixman.h> | ||
| #include <wlr/render/wlr_renderer.h> | ||
| #include <wlr/types/wlr_drm.h> |
Collaborator
There was a problem hiding this comment.
不应该实现wlr_renderer。只需要实现pixman\vulkan\gles后端
| #include "render/pixel_format.h" | ||
| #include "types/wlr_buffer.h" | ||
|
|
||
| void wlr_texture_init(struct wlr_texture *texture, struct wlr_renderer *renderer, |
Collaborator
|
pixman要评估一下，是否可以不用自己实现？用wlroot上的wlr_pixman_renderer_create |
Groveer
force-pushed
the
agent/developer/0f3af415
branch
8 times, most recently
from
July 13, 2026 12:52
bd26afa to
2cffc9f
Compare
…derer Phase 1 — RHI path damage tracking: - Add WSGDamageTracker: collects dirty nodes via nodeChanged() callback (Qt 6.8 removed QSGNode::m_dirtyState), accumulates bounding boxes with DirtyDamageMask including DirtyMatrix - Add WSGDirtyNodeObserver: passive QSGAbstractRenderer registered on root node to receive nodeChanged() without displacing the real renderer - Wire into WBufferRenderer::ensureRenderer/render/destroySource - Replace m_damageRing.add_whole() with scanned dirty-node damage, combined with rotate_buffer() damage - Add Y-flip for mirrorVertically() scenarios - Add unit tests (18 cases covering all dirty flags, edge cases, Y-flip) Phase 2 — vendored wlroots 0.19 renderer: - Vendor gles2/vulkan/pixman backends, egl, dmabuf, allocator, swapchain infrastructure under sgrenderer/vendor/wlroots/ - Extension headers exposing buffer->FBO/Image conversion, texture handles, EGL context management for BAL consumption - CMake target waylib_sgrenderer_wlroots_vendor (static lib) - All Code Review fixes applied: underscore shader header names, wlr_egl_context for surface access, conditional WLR_HAS_GBM_ALLOCATOR, unified config.h includes, glslangValidator FATAL_ERROR Both phases passed Code Review.
Groveer
force-pushed
the
agent/developer/0f3af415
branch
from
July 13, 2026 13:45
1ec668d to
a3175b8
Compare
|
TAG Bot New tag: 0.8.15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
为 waylib 实现全新的 QSGRenderer，支持 damage 跟踪并 vendor wlroots 渲染后端。
Implement a new QSGRenderer for waylib with damage tracking and vendored wlroots renderer backends.
Phase 1 — RHI path damage tracking
WSGDamageTracker: collects dirty nodes vianodeChanged()callback (Qt 6.8 removedQSGNode::m_dirtyState), accumulates bounding boxes withDirtyDamageMaskincludingDirtyMatrixWSGDirtyNodeObserver: passiveQSGAbstractRendererregistered on root node to receivenodeChanged()without displacing the real rendererWBufferRenderer::ensureRenderer/render/destroySourcem_damageRing.add_whole()with scanned dirty-node damage, combined withrotate_buffer()damagemirrorVertically()scenariosPhase 2 — vendored wlroots 0.19 renderer
sgrenderer/vendor/wlroots/waylib_sgrenderer_wlroots_vendor(static lib)wlr_egl_contextfor surface access, conditionalWLR_HAS_GBM_ALLOCATOR, unifiedconfig.hincludes,glslangValidator FATAL_ERRORBoth phases passed Code Review (18 unit tests).
Multica issue: WM-79