Skip to content

fix: build error on Windows#757

Open
kt286 wants to merge 1 commit into
linuxdeepin:masterfrom
kt286:fix/build_on_msys2
Open

fix: build error on Windows#757
kt286 wants to merge 1 commit into
linuxdeepin:masterfrom
kt286:fix/build_on_msys2

Conversation

@kt286

@kt286 kt286 commented Jul 16, 2026

Copy link
Copy Markdown

fix build error on Windows

sourcery-ai[bot]
sourcery-ai Bot reviewed Jul 16, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @kt286, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Warning

[Debian检查]

  • 检测到敏感词export变动
详情 
    {
    "export": {
        "dtkwidget.cmake": {
            "b": [
                "  set(CMAKE_SHARED_LINKER_FLAGS \"${CMAKE_SHARED_LINKER_FLAGS} -Wl,--export-all-symbols\")"
            ]
        }
    }
}

@deepin-ci-robot

deepin-ci-robot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Hi @kt286. Thanks for your PR. 😃

@deepin-ci-robot

deepin-ci-robot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Hi @kt286. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BLumia
BLumia reviewed Jul 16, 2026
View reviewed changes
Comment thread src/widgets/private/startupnotifications/startupnotificationmonitor.cpp
@deepin-bot

deepin-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 6.7.46
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #758

@kt286
kt286 force-pushed the fix/build_on_msys2 branch from da4aab4 to 6ea79dd Compare July 17, 2026 05:42
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Warning

[Debian检查]

  • 检测到敏感词export变动
详情 
    {
    "export": {
        "dtkwidget.cmake": {
            "b": [
                "  set(CMAKE_SHARED_LINKER_FLAGS \"${CMAKE_SHARED_LINKER_FLAGS} -Wl,--export-all-symbols\")"
            ]
        }
    }
}

alvarosamudio added a commit to alvarosamudio/tetris that referenced this pull request Jul 17, 2026
@alvarosamudio
fix: Windows build compatibility
dd6cc1d 
Guard DTK-specific includes and classes with #ifdef Q_OS_LINUX,
using plain Qt6 equivalents (QApplication, QMainWindow) as fallbacks
for non-Linux platforms. dtk6widget pkg-config and install paths
wrapped in linux {} scope in the .pro file.

Pattern based on linuxdeepin/dtkwidget#757.
alvarosamudio added a commit to alvarosamudio/tetris that referenced this pull request Jul 17, 2026
@alvarosamudio
fix: Windows build compatibility
273313f 
Guard DTK-specific includes and classes with #ifdef Q_OS_LINUX,
using plain Qt6 equivalents (QApplication, QMainWindow) as fallbacks
for non-Linux platforms. dtk6widget pkg-config and install paths
wrapped in linux {} scope in the .pro file.

Pattern based on linuxdeepin/dtkwidget#757.
@BLumia
BLumia requested a review from 18202781743 July 22, 2026 02:03
18202781743
18202781743 reviewed Jul 23, 2026
View reviewed changes
Comment thread src/widgets/private/keyboardmonitor/dkeyboardmonitor.h Outdated
18202781743
18202781743 reviewed Jul 23, 2026
View reviewed changes
Comment thread src/widgets/dprintpreviewwidget.cpp
@kt286
kt286 force-pushed the fix/build_on_msys2 branch from 6ea79dd to abc7f6f Compare July 23, 2026 12:42
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Warning

[Debian检查]

  • 检测到敏感词export变动
详情 
    {
    "export": {
        "dtkwidget.cmake": {
            "b": [
                "  set(CMAKE_SHARED_LINKER_FLAGS \"${CMAKE_SHARED_LINKER_FLAGS} -Wl,--export-all-symbols\")"
            ]
        }
    }
}

@kt286
kt286 requested review from 18202781743 and BLumia July 23, 2026 12:42
18202781743
18202781743 previously approved these changes Jul 23, 2026
View reviewed changes
BLumia
BLumia reviewed Jul 24, 2026
View reviewed changes
Comment thread src/widgets/dimageviewer.cpp Outdated
@kt286
kt286 force-pushed the fix/build_on_msys2 branch from abc7f6f to 531d1b7 Compare July 24, 2026 06:17
@deepin-ci-robot

deepin-ci-robot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kt286

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@deepin-ci-robot

deepin-ci-robot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kt286

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Warning

[Debian检查]

  • 检测到敏感词export变动
详情 
    {
    "export": {
        "dtkwidget.cmake": {
            "b": [
                "  set(CMAKE_SHARED_LINKER_FLAGS \"${CMAKE_SHARED_LINKER_FLAGS} -Wl,--export-all-symbols\")"
            ]
        }
    }
}

@kt286
fix: make dtkwidget buildable on Windows/MSYS2
66a3da5 
Guard Linux-only code (CUPS printing, X11 keyboard monitor, startup
notification, XInput2 SVG rendering) behind #ifdef Q_OS_LINUX so they
are excluded from the Windows build. Remove pkg_check_modules for
Linux-only dependencies when not on Linux. Export all symbols on
Windows/MinGW and add missing Qt::Svg dependency.
@kt286
kt286 force-pushed the fix/build_on_msys2 branch from 531d1b7 to 66a3da5 Compare July 24, 2026 06:19
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Warning

[Debian检查]

  • 检测到敏感词export变动
详情 
    {
    "export": {
        "dtkwidget.cmake": {
            "b": [
                "  set(CMAKE_SHARED_LINKER_FLAGS \"${CMAKE_SHARED_LINKER_FLAGS} -Wl,--export-all-symbols\")"
            ]
        }
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BLumia BLumia BLumia left review comments
@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments
@18202781743 18202781743 18202781743 left review comments
@liujianqiang-niu liujianqiang-niu Awaiting requested review from liujianqiang-niu

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kt286 @deepin-ci-robot @BLumia @18202781743