Skip to content

fix: build error on Windows#649

Open
kt286 wants to merge 2 commits into
linuxdeepin:masterfrom
kt286:fix/build_on_msys2
Open

fix: build error on Windows#649
kt286 wants to merge 2 commits into
linuxdeepin:masterfrom
kt286:fix/build_on_msys2

Conversation

@kt286

@kt286 kt286 commented Jul 16, 2026

Copy link
Copy Markdown

fix build error on Windows

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @kt286, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

Hi @kt286. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BLumia BLumia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先评注这个比较显而易见的...

Comment thread qt6/src/qml/AboutDialog.qml
@deepin-bot

deepin-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 6.7.46
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #650

Comment thread CMakeLists.txt Outdated
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC -Wextra")

# Export all symbols for MinGW since DTK classes lack export macros
if(WIN32 AND NOT MSVC)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里目前应该不用处理吧,外部使用dtkdeclarative一般是通过qml的uri方式,目前不导出符号应该没问题,

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不导出自己都编译不过去
PixPin_2026-07-21_21-39-40

Comment thread qt6/src/qml/AboutDialog.qml Outdated
Comment thread src/dquickwindow.cpp Outdated
Comment thread src/private/dqmlglobalobject.cpp Outdated
@kt286
kt286 force-pushed the fix/build_on_msys2 branch from 66f9ee9 to 7ded0c7 Compare July 21, 2026 13:47
@kt286
kt286 requested review from 18202781743 and BLumia July 21, 2026 13:49
@kt286

kt286 commented Jul 21, 2026

Copy link
Copy Markdown
Author

/retest

@kt286
kt286 force-pushed the fix/build_on_msys2 branch from f982f20 to fe2c812 Compare July 22, 2026 02:06
Comment thread src/private/dquickdciiconimage.cpp Outdated
Comment thread src/dquickwindow.cpp Outdated
@kt286
kt286 force-pushed the fix/build_on_msys2 branch from fe2c812 to dc19417 Compare July 23, 2026 09:34
@kt286
kt286 requested a review from 18202781743 July 23, 2026 09:40
@kt286
kt286 force-pushed the fix/build_on_msys2 branch from dc19417 to 4d096cb Compare July 23, 2026 09:50
Comment thread qt6/src/qml/DialogWindow.qml Outdated
Comment thread src/qml/DialogWindow.qml Outdated
Guard Linux-specific linker flags and platform assertions with
appropriate #ifdefs so the project compiles on MinGW. Add DBus Qt
dependency, export all symbols for MinGW, and add null checks in
DSGBlendNode::render for OpenGL context/functions.
@kt286
kt286 force-pushed the fix/build_on_msys2 branch from 4d096cb to 0b29c1b Compare July 23, 2026 12:25
@kt286
kt286 requested a review from 18202781743 July 23, 2026 12:25
18202781743
18202781743 previously approved these changes Jul 23, 2026
Comment thread src/targets.cmake
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kt286

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kt286

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

use qt_add_resources for MSYS2 compatibility
@kt286
kt286 force-pushed the fix/build_on_msys2 branch from 6f631db to e317e1f Compare July 24, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants