Skip to content

Refactor: fix nextPage() boundery bug and other issues#249

Open
SiamSami wants to merge 3 commits intolinuxdeepin:masterfrom
SiamSami:master
Open

Refactor: fix nextPage() boundery bug and other issues#249
SiamSami wants to merge 3 commits intolinuxdeepin:masterfrom
SiamSami:master

Conversation

@SiamSami
Copy link

The PR does the following,

  1. Fixed nextPage() boundary bug
  2. Removed duplicated navigation logic via a helper
  3. Switched to modern signal/slot syntax
  4. Centralized bookmark button state logic
  5. Renamed bIshandOpenSuccessm_openHandled

Refactor BookMarkWidget for improved structure and clarity.
Removed commented sections for new helpers and core logic.
Removed commented navigation section in BookMarkWidget.
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SiamSami

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

Hi @SiamSami. Thanks for your PR. 😃

@deepin-ci-robot
Copy link

Hi @SiamSami. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants