Repository navigation
feat: update reset password flow to log out user on success - #868
Open
CasLubbers wants to merge 2 commits into
Open
CasLubbers wants to merge 2 commits into
CasLubbers wants to merge 2 commits into
Conversation
Signed-off-by: Cas Lubbers <clubbers@akamai.com>
CasLubbers
requested review from
dennisvankekem and
ferruhcihan
as code owners
November 6, 2026 16:24
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Immediate full-page navigation discards the password-reset confirmation and login instruction before users can reliably read them; the message needs to persist across navigation or appear at the destination.
1 open issue
What changed in this PR
Updates the password-reset flow to log users out after a successful reset, preventing the browser from continuing with an old token.
Changes:
- Redirects successful resets to
/platform-logoutinstead of clearing and closing the modal. - Updates the success message to request a new login.
- Adjusts tests to verify logout navigation on success, no navigation on failure, and a 400 rejection case.
| File | Description |
|---|---|
src/components/modals/ResetPasswordModal.tsx |
Adds logout navigation and revised confirmation text after a successful reset. |
src/components/modals/ResetPasswordModal.test.tsx |
Mocks navigation and updates success and rejection assertions. |
Review effort: Balanced
Comment on lines
+168
to
+169
| snack.success('Password reset successfully, please log in again') | ||
| window.location.assign('/platform-logout') |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Together with: linode/apl-api#1126