Skip to content

LCORE-1428: Address former MCP auth failure #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisnik merged 2 commits into from
Mar 25, 2026
Merged

LCORE-1428: Address former MCP auth failure #1400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97bd6af
LCORE-1428: Re-enable MCP auth e2e tests in library mode
max-svistunov Mar 24, 2026
73c2216
LCORE-1428: Increase container health-check timeout for e2e restarts
max-svistunov Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions tests/e2e/features/mcp.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ Feature: MCP tests
Then The status code of the response is 200
And The body of the response contains mcp-file

@skip-in-library-mode #TODO: LCORE-1428
@MCPFileAuthConfig
Scenario: Check if query endpoint succeeds when MCP file-based auth token is passed
Given The system is in default state
Expand All @@ -31,7 +30,6 @@ Feature: MCP tests
| Hello |
And The token metrics should have increased

@skip-in-library-mode #TODO: LCORE-1428
@MCPFileAuthConfig
Scenario: Check if streaming_query endpoint succeeds when MCP file-based auth token is passed
Given The system is in default state
Expand Down Expand Up @@ -113,7 +111,6 @@ Feature: MCP tests
Then The status code of the response is 200
And The body of the response contains mcp-kubernetes

@skip-in-library-mode #TODO: LCORE-1428
@MCPKubernetesAuthConfig
Scenario: Check if query endpoint succeeds when MCP kubernetes auth token is passed
Given The system is in default state
Expand All @@ -129,7 +126,6 @@ Feature: MCP tests
| Hello |
And The token metrics should have increased

@skip-in-library-mode #TODO: LCORE-1428
@MCPKubernetesAuthConfig
Scenario: Check if streaming_query endpoint succeeds when MCP kubernetes auth token is passed
Given The system is in default state
Expand Down Expand Up @@ -253,7 +249,6 @@ Feature: MCP tests
Then The status code of the response is 200
And The body of the response contains mcp-client

@skip-in-library-mode #TODO: LCORE-1428
@MCPClientAuthConfig
Scenario: Check if query endpoint succeeds when MCP client-provided auth token is passed
Given The system is in default state
Expand All @@ -272,7 +267,6 @@ Feature: MCP tests
| Hello |
And The token metrics should have increased

@skip-in-library-mode #TODO: LCORE-1428
@MCPClientAuthConfig
Scenario: Check if streaming_query endpoint succeeds when MCP client-provided auth token is passed
Given The system is in default state
Expand Down Expand Up @@ -422,7 +416,6 @@ Feature: MCP tests
Then The status code of the response is 200
And The body of the response contains mcp-oauth

@skip-in-library-mode #TODO: LCORE-1428
@MCPOAuthAuthConfig
Scenario: Check if query endpoint succeeds when MCP OAuth auth token is passed
Given The system is in default state
Expand All @@ -441,7 +434,6 @@ Feature: MCP tests
| Hello |
And The token metrics should have increased

@skip-in-library-mode #TODO: LCORE-1428
@MCPOAuthAuthConfig
Scenario: Check if streaming_query endpoint succeeds when MCP OAuth auth token is passed
Given The system is in default state
Expand Down
7 changes: 5 additions & 2 deletions tests/e2e/utils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,11 @@ def restart_container(container_name: str) -> None:
print(f"Failed to restart container {container_name}: {e.stderr!s}")
raise

# Wait for container to be healthy
wait_for_container_health(container_name)
# Wait for container to be healthy.
# Library mode embeds llama-stack, so the container takes longer to start
# (~45-60s vs ~10s in server mode). Use a generous attempt count so
# MCP-auth scenarios that restart the container don't time out.
wait_for_container_health(container_name, max_attempts=12)


def replace_placeholders(context: Context, text: str) -> str:
Expand Down
Loading