Skip to content

Bump libigl and align sparse marching_cubes with dense E2V behavior - #310

Open
alecjacobson with Copilot wants to merge 7 commits into
mainfrom
copilot/bump-libigl-marching-cubes
Open

Bump libigl and align sparse marching_cubes with dense E2V behavior#310
alecjacobson with Copilot wants to merge 7 commits into
mainfrom
copilot/bump-libigl-marching-cubes

Conversation

Copilot AI commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

This updates the libigl pin to 72217e00bae6a7e041221e187aafbdc793f905d2 and brings the sparse-grid igl.marching_cubes binding in line with the dense overload by returning the edge-to-vertex map (E2V).

  • Dependency update

    • Bump the vendored libigl revision in CMakeLists.txt to 72217e00bae6a7e041221e187aafbdc793f905d2.
  • Binding behavior

    • Change the sparse-grid marching_cubes(S, GV, GI, isovalue) binding to call the libigl overload that returns E2V.
    • Make the Python return signature consistent across dense and sparse variants:
      • dense: (V, F, E2V)
      • sparse: now also (V, F, E2V)
  • API/docs

    • Update the sparse overload docstring to document E2V.
    • Clarify the unpacking example for the returned edge map.
  • Tests

    • Update the sparse marching-cubes coverage to unpack and validate E2V.
    • Handle empty maps safely when converting the returned dictionary into a NumPy array.

Example:

V, F, E2V = igl.marching_cubes(unique_S, unique_corners, J, 0.0)

E2V_triplets = np.array(
    [[k & 0xFFFFFFFF, k >> 32, v] for k, v in E2V.items()],
    dtype=np.int64,
) if E2V else np.empty((0, 3), dtype=np.int64)

Copilot AI and others added 7 commits August 20, 2026 19:37
Co-authored-by: alecjacobson <2241689+alecjacobson@users.noreply.github.com>
Co-authored-by: alecjacobson <2241689+alecjacobson@users.noreply.github.com>
Co-authored-by: alecjacobson <2241689+alecjacobson@users.noreply.github.com>
Co-authored-by: alecjacobson <2241689+alecjacobson@users.noreply.github.com>
Co-authored-by: alecjacobson <2241689+alecjacobson@users.noreply.github.com>
Co-authored-by: alecjacobson <2241689+alecjacobson@users.noreply.github.com>
Co-authored-by: alecjacobson <2241689+alecjacobson@users.noreply.github.com>
Copilot AI changed the title Bump libigl and return E2V for sparse marching_cubes Bump libigl and align sparse marching_cubes with dense E2V behavior Aug 20, 2026
Copilot AI requested a review from alecjacobson August 20, 2026 19:49
@alecjacobson
alecjacobson marked this pull request as ready for review August 22, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants