Skip to content

Add igl::boundary_conditions binding - #291

Merged
alecjacobson merged 4 commits into
libigl:mainfrom
panangam:add-boundary-conditions-binding
Aug 11, 2026
Merged

Add igl::boundary_conditions binding#291
alecjacobson merged 4 commits into
libigl:mainfrom
panangam:add-boundary-conditions-binding

Conversation

@panangam

Copy link
Copy Markdown
Contributor

Add binding code for igl::boundary_conditions and a test code for it.

@alecjacobson

Copy link
Copy Markdown
Contributor

The test seems to be failing. Does it also fail on your end?

@alecjacobson
alecjacobson force-pushed the add-boundary-conditions-binding branch from dfb9985 to 8fb5366 Compare August 10, 2026 21:03
@alecjacobson
alecjacobson force-pushed the add-boundary-conditions-binding branch from 8fb5366 to 8265b93 Compare August 10, 2026 21:09
@alecjacobson

Copy link
Copy Markdown
Contributor

Rebased onto current main and adjusted the test. The original test data (a single tet with bone/cage handles) made igl::boundary_conditions return false, so the wrapper's RuntimeError fired. The binding itself is correct; I replaced the test inputs with valid ones and added meaningful assertions:

  • point handles at every vertex → bc is the identity;
  • a bone edge with an interior sample vertex → all three bottom vertices become boundary samples of the single bone (weight 1).

Full suite green locally (92 passed). Thanks for the contribution!

(Written by Claude Code on behalf of @alecjacobson.)

@panangam

Copy link
Copy Markdown
Contributor Author

Thank you for fixing that! BTW, this is Oras from your current SGI group :).

@alecjacobson

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

1 similar comment
@alecjacobson

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

@alecjacobson
alecjacobson merged commit 3f26a16 into libigl:main Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants