USB Enumeration V2#100
Open
kammce wants to merge 11 commits into
Open
Conversation
- Fix UB bug with bit_value operator= - Fix const for get() in bit_value
- Add configuration_totals struct to return both length and interface count - Update prepare_descriptors to return configuration_totals - Use actual interface count from prepare_descriptors in generate_configuration_descriptor - Fixes issue where second CDC interface wasn't properly enumerated
PhazonicRidley
requested changes
May 17, 2026
| return; | ||
| } | ||
|
|
||
| auto event = *m_event; |
There was a problem hiding this comment.
nit: m_event.value() more readable and clear that this is an optional, not a pointer
| using hal::v5::scatter_span_size; | ||
| using hal::v5::sub_scatter_result; | ||
|
|
||
| class enumerator |
There was a problem hiding this comment.
Assuming this will be the default single configuration enumerator. If I want a multi-config descriptor one I can make that its own thing (I want it for POC purposes not actual use). Do we want to factor some of this out so people can build their own enumerators? Not this PR, just an idea.
| }; | ||
|
|
||
| template<usize InterfaceCount> | ||
| class inplace_enumerator : public enumerator |
There was a problem hiding this comment.
Pretty self-evident but documentation for API docs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.