trees/tiles: Add TileReader and ReadEntries - #8956
Merged
Merged
Conversation
beautifulentropy
marked this pull request as ready for review
August 18, 2026 15:44
beautifulentropy
requested review from
aarongable,
ezekiel and
jsha
and removed request for
jsha
August 18, 2026 15:44
beautifulentropy
force-pushed
the
paving-a-path-to-a-proper-publisher-05
branch
from
August 18, 2026 21:07
e5dd924 to
115aebe
Compare
Member
Author
|
Apologies for the force push. I am cherry-picking some interface changes that really belong in this PR from my working branch. |
beautifulentropy
force-pushed
the
paving-a-path-to-a-proper-publisher-05
branch
from
August 18, 2026 21:19
115aebe to
1a890cb
Compare
aarongable
reviewed
Aug 18, 2026
beautifulentropy
force-pushed
the
paving-a-path-to-a-proper-publisher-05
branch
from
August 19, 2026 21:18
2882a10 to
94e5180
Compare
beautifulentropy
force-pushed
the
paving-a-path-to-a-proper-publisher-05
branch
from
August 19, 2026 21:21
94e5180 to
2798b11
Compare
aarongable
approved these changes
Aug 19, 2026
aarongable
left a comment
aarongable
left a comment
Contributor
There was a problem hiding this comment.
Awesome, love the new EntriesForPackage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, narrow the interface for the s3c used on read-only trees/tiles functions.
Closes #8946