refactor(api): inline import-time _routes global into start()#983
Merged
tcoratger merged 1 commit intoJun 12, 2026
Merged
Conversation
Build the aiohttp route list inside start() instead of at module import time. This removes an import-time side effect and a module-level global that was only ever read in one place. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The API server module built its aiohttp route list in a module-level
_routesglobal at import time.This created an import-time side effect, and the value was only ever read once, inside
start().This change moves the route-list construction into
start()as a local variable and removes the global.Behavior is unchanged: the same routes are registered on the application before the server starts.
Testing
uv run pytest tests/node/api/test_server.py -q(19 passed)just check(lint, format, typecheck, spell, mdformat, lock) all pass🤖 Generated with Claude Code