refactor(sync): drop write-only HeadSyncResult.error field#978
Merged
tcoratger merged 1 commit intoJun 12, 2026
Merged
Conversation
The error field was assigned on the processing-failure path but never read anywhere. The SyncService only branches on the processed flag. Remove the field, its sole assignment, and the test assertion that set it; rename the test to describe the now-accurate behavior (errors are swallowed and reported as not processed, never raised). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HeadSyncResult.errorwas a write-only field: it was assigned on the block-processing failure path but never read anywhere insrc/,packages/, ortests/. TheSyncServiceonly branches on theprocessedflag.This drops the dead field and its single assignment site, keeping
HeadSyncResultminimal and the spec readable.Changes
errorfield and its docstring fromHeadSyncResult.error=assertion and rename the test to describe the now-accurate behavior — a processing failure is swallowed, reported as not processed, and never raised.Verification
grepconfirms.erroris never read on aHeadSyncResult(only unrelatedlogger.errorcalls match).uv run pytest tests/node/sync/test_head_sync.py— 13 passed.just check— clean (ruff, format, ty, codespell, mdformat).🤖 Generated with Claude Code