refactor(quic): dedup QuicConnection construction sites#975
Closed
tcoratger wants to merge 1 commit into
Closed
Conversation
Both the outbound connect path and the inbound handshake callback built a QuicConnection, wired it onto the protocol, replayed buffered events, and registered it in the connections map with identical steps. Factor that shared sequence into a single private method on the manager so the two sites share one construction path. Behavior is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The QUIC connection manager built a
QuicConnectionin two places withidentical wiring:
connectpath, andlistenhandshake callback.Both constructed the connection, assigned it back onto the protocol, replayed
buffered events, and registered it in the connections map. This change factors
that shared sequence into a single private
_register_connectionmethod so thetwo sites share one construction path.
Behavior
Unchanged. The two sites differ only in the protocol instance, peer ID, and
remote address; those become the method's parameters. No on-the-wire or public
API change.
Testing
uv run pytest tests/node/networking/transport/quic/test_connection.py -q— 74 passed.just check— all checks pass (lint, format, type check, spell, mdformat, lock).🤖 Generated with Claude Code