refactor(quic): finish_write delegates to drain#973
Merged
tcoratger merged 1 commit intoJun 12, 2026
Merged
Conversation
The half-close path duplicated the buffer-flush logic already implemented by the drain method. Route the flush through drain so the two paths share one implementation and stay consistent. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The QUIC stream adapter's half-close path duplicated the buffer-flush logic already implemented by the drain method. This routes the flush through drain so both paths share a single implementation and cannot drift apart.
Change
finish_writenow callsawait self.drain()to flush the write buffer, then sends FIN via the underlying stream. The extra finalization (sending FIN) is preserved; only the duplicated flush logic is consolidated.Behavior is unchanged: drain performs the exact same buffer flush that was previously inlined.
Verification
uv run pytest tests/node/networking/transport/quic/test_stream_adapter.py— 52 passedjust check— all checks passed🤖 Generated with Claude Code