refactor(ssz): lift shared coerce/shape logic out of vector and list#971
Merged
tcoratger merged 1 commit intoJun 12, 2026
Merged
Conversation
The vector and list before-validators duplicated the input-shaping block that rejects strings and non-iterables and materializes other iterables into a length-checkable sequence. Lift that shaping into one shared base-class method on the sequence scaffolding. Each subclass keeps only its distinct misconfiguration message and its own element-count rule. All exception messages are preserved exactly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The before-validators on the fixed-length vector and the variable-length list each repeated the same input-shaping block: reject strings and bytes (which would silently iterate into characters or ints), reject non-iterables, and materialize any other iterable into a length-checkable sequence.
This lifts that shaping into one shared classmethod on the sequence scaffolding base. Each subclass now keeps only the two things that genuinely differ:
Behavior
Behavior-preserving. Every exception message is reproduced byte-for-byte:
<Type>: Expected iterable of <Element>, got <type><Type>: Expected iterable, got <type>Verified against the full-equality message assertions in
tests/spec/ssz/test_collections.py(98 passed).just checkis clean.🤖 Generated with Claude Code