refactor(testing): inline single-use _serialize_ssz_value#970
Merged
tcoratger merged 1 commit intoJun 12, 2026
Merged
Conversation
The serializer helper had exactly one caller. Inline its body at the field serializer; the helper docstring matched the method docstring, so the method keeps it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SSZ-to-JSON conversion helper had exactly one caller, the field serializer on the emitted SSZ fixture. Per the repository preference to inline single-use helpers, its body now lives directly in the serializer.
The helper's docstring was identical to the method's existing docstring, so the method keeps that docstring, and the Boolean-before-int ordering comment moves inline with the body.
Testing
just checkpasses (lint, format, type check, codespell, mdformat).🤖 Generated with Claude Code