refactor(storage): dedup blocks/states keep-roots pruning branch#969
Merged
tcoratger merged 1 commit intoJun 12, 2026
Merged
Conversation
The pruning routine repeated identical keep-roots delete logic for the blocks and states tables, differing only in the table name. Both tables share the same root and slot columns, so route both through a single nested helper parameterized by table name. SQL semantics are unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pruning routine in the SQLite storage backend repeated identical keep-roots delete logic for the blocks and states tables, differing only in the table name. Since both tables share the same
rootandslotcolumns, this collapses the two branches into a single nested helper parameterized by table name.NOT INexclusion is built when roots are kept, and the clause is omitted for an empty keep set to avoid invalid empty parentheses.Testing
uv run pytest tests/node/storage/test_sqlite.py— 36 passed.just check— clean (lint, format, typecheck, spell, mdformat, lock).🤖 Generated with Claude Code