Skip to content

fix: checkbox overlap in datatables - #1755

Open
KhushamBansal wants to merge 1 commit into
layer5io:masterfrom
KhushamBansal:fix/checkbox
Open

fix: checkbox overlap in datatables#1755
KhushamBansal wants to merge 1 commit into
layer5io:masterfrom
KhushamBansal:fix/checkbox

Conversation

@KhushamBansal

@KhushamBansal KhushamBansal commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Notes for Reviewers

This fixes an issue where the sticky checkbox column was transparent, causing horizontal scroll text to overlap. Removed !important from MuiTableCell root background to allow MUIDataTableSelectCell to have a solid background, and added matching linear-gradient hover states.

This PR fixes #

Before:

Screen.Recording.2026-07-27.at.2.19.14.PM.mov

After:

Screen.Recording.2026-07-27.at.2.18.43.PM.mov

Signed commits

  • Yes, I signed my commits.

Summary by CodeRabbit

  • Style
    • Improved table cell backgrounds for clearer visual consistency.
    • Added theme-aware colors for selected table cells, including hover states.
    • Enhanced table header appearance in dark mode.

…ckbox cell overlap

This fixes an issue where the sticky checkbox column was transparent, causing horizontal scroll text to overlap. Removed !important from MuiTableCell root background to allow MUIDataTableSelectCell to have a solid background, and added matching linear-gradient hover states.

Signed-off-by: KhushamBansal <kbkhushambansal@gmail.com>
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ce0e896e-eb9b-4ccd-96ed-158655ca54f5

📥 Commits

Reviewing files that changed from the base of the PR and between 846866a and 19b2acb.

📒 Files selected for processing (1)
  • src/theme/components/table.modifier.ts

📝 Walkthrough

Walkthrough

Updated table theme styling to remove an !important override and apply theme-driven backgrounds, row hover gradients, and light/dark head-cell colors to selection cells.

Changes

Table theme styling

Layer / File(s) Summary
Table background styling
src/theme/components/table.modifier.ts
MuiTableCell no longer forces transparent backgrounds with !important; MUIDataTableSelectCell now derives backgrounds from theme values, adds row hover styling, and applies mode-specific head-cell colors.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main fix: resolving checkbox overlap in data tables.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Bhumikagarggg
Bhumikagarggg self-requested a review July 27, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants