fix(navigation): apply theme-consistent scrollbar styling to mobile dropdown - #7942
fix(navigation): apply theme-consistent scrollbar styling to mobile dropdown#7942D-source1602 wants to merge 3 commits into
Conversation
…ropdown Fixes layer5io#7904 The .mobile-dropdown scrollbar was using hardcoded gray values (#cbced1 track, #868e96 thumb) instead of the theme variables used by the global page scrollbar in app.style.js. Replace with props.theme.scrollbarColor for the thumb and props.theme.body for the track, and add the Firefox scrollbar-color property for cross-browser consistency. Signed-off-by: Debjit Chauhan <DebjitChauhan5@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe mobile navigation dropdown scrollbar now uses theme-provided colors for its track and thumb. The standard scrollbar receives the same themed color pair. ChangesNavigation scrollbar styling
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: dependency version conflict. Check your lock file or package.json. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dhruveshmishra
left a comment
There was a problem hiding this comment.
@D-source1602 can u attach the screenshot or screen recording in the pr description for your changes
|
Hi @dhruveshmishra, here's the visual explanation of the change: Before (hardcoded gray):
After (theme-aware):
I will attach a screenshot once I have the local dev environment running. |
|
Preview deployment for PR #7942 removed. This PR preview was automatically pruned because we keep only the 3 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
Fixes #7904
Problem--
The "mobile-dropdown "scrollbar inside the navigation menu was using hardcoded gray values (
#cbced1track,#868e96thumb), while the page scrollbar uses "theme.scrollbarColor"from "app.style.js" — resulting in visual inconsistency between the two.Solution--
Replaced the hardcoded colors in "navigation.style.js" with the same theme variables used globally:
In dark mode,
scrollbarColorresolves to#00d3a9(Layer5 green). In light mode it resolves to#3c494f(charcoal), matching the page scrollbar in both themes.Files changed--
Summary by CodeRabbit