Skip to content

Fix sidebar layout shift on Sistent page refresh #7938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Katotodan wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −3
Open

Fix sidebar layout shift on Sistent page refresh #7938

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e556859
fix sistent's page layout issue
Katotodan Aug 7, 2026
75713e5
Merge branch 'master' into fix/sitent-component-pg-layout
Katotodan Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/components/SistentNavigation/toc.style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const TOCWrapper = styled.div`
margin-left: 3rem;
margin-top: 3rem;
width: 15rem;
min-width: 15rem;

@coderabbitai coderabbitai Bot Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Reset the minimum width in the mobile layout.

TOCWrapper already has width: 15rem on Line 9, so this rule does not add a desktop width reservation. The max-width: 750px media query changes width to auto but leaves min-width: 15rem active. On narrow viewports, this can cause horizontal overflow together with margin-right: 3rem.

Add min-width: 0 in the mobile media query, or scope this rule to the desktop layout.

As per coding guidelines, the component must maintain responsive mobile-first behavior.

Proposed fix 
 `@media` only screen and (max-width: 750px) {
   position: initial;
   margin-right: 3rem;
   width: auto;
+  min-width: 0;
 }
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/SistentNavigation/toc.style.js` at line 10, Reset TOCWrapper’s
min-width within the max-width: 750px mobile media query by setting it to 0,
while preserving the existing desktop width and mobile auto-width behavior to
prevent narrow-screen overflow.

Source: Coding guidelines

@Katotodan Katotodan Aug 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this on small devices, and everything was working correctly. The size set for small devices was superior to 15rem already so that prevents it from even shrinking in any unknown senario.

@coderabbitai coderabbitai Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katotodan, the tested devices validate the current layout at those viewport sizes.

The concern is limited to a narrower available content width. In the mobile media query, width: auto does not override min-width: 15rem. The wrapper can therefore not shrink below 15rem, regardless of the available width after margins.

If the supported mobile viewport and container widths always exceed that limit, the current rule is safe. Otherwise, reset min-width in the mobile media query to preserve the intended width: auto behavior.

(ᵕ•_•) 🐇

You are interacting with an AI system.

padding-bottom: 2rem;
@media screen and (min-width: 1280px) and (max-width: 1350px) {
margin-left: 0.2rem;
Expand Down Expand Up @@ -135,7 +136,9 @@ const TOCWrapper = styled.div`
background-color: transparent;
}

.identity, .components, .getting-started {
.identity,
.components,
.getting-started {
display: flex;
width: 100%;
justify-content: space-between;
Expand All @@ -148,10 +151,12 @@ const TOCWrapper = styled.div`
}
}

.identity-sublinks, .components-sublinks {
.identity-sublinks,
.components-sublinks {
padding-left: 0.56rem;

.identity-item, .components-item {
.identity-item,
.components-item {
font-size: 1.05rem;
margin-top: 0.45rem;
}
Expand Down