Skip to content

fix(deps): bump rand from 0.8.5 to 0.10.1#129

Merged
keelerm84 merged 1 commit intomainfrom
mk/sdk-2164/bump-rand
Apr 13, 2026
Merged

fix(deps): bump rand from 0.8.5 to 0.10.1#129
keelerm84 merged 1 commit intomainfrom
mk/sdk-2164/bump-rand

Conversation

@keelerm84
Copy link
Copy Markdown
Member

@keelerm84 keelerm84 commented Apr 13, 2026

Summary

Bumps the rand dependency from 0.8.5 to 0.10.1 to address a customer-reported security concern with the older version.

The only usage of rand is in retry.rs for jitter calculation during backoff. The rand 0.10 API changes required updating:

  • thread_rng()rand::rng()
  • gen_range() (via Rng trait) → random_range() (via RngExt trait)

The range semantics (current_delay / 2..=current_delay) are unchanged.

Review & Testing Checklist for Human

  • Verify the rand::RngExt trait import and rand::rng().random_range(...) call are idiomatic for rand 0.10
  • Confirm the updated dependency resolves the specific security concern from the reported issue
  • Check CI passes — all 59 unit tests passed locally

Notes

This is a major version bump (0.8 → 0.10), but the API surface used by this crate is minimal (single call site), so the migration is straightforward.

Link to Devin session: https://app.devin.ai/sessions/6f753c80cc4d4afabef3354af1b1eeb6
Requested by: @keelerm84


Note

Low Risk
Low risk: a dependency bump with a single call-site update for jitter generation; behavior should remain the same aside from potential RNG implementation differences.

Overview
Updates the rand dependency from 0.8.5 to 0.10.1.

Adjusts retry backoff jitter generation in retry.rs to the new rand API by switching to RngExt and replacing thread_rng().gen_range(...) with rand::rng().random_range(...) while keeping the jitter range semantics unchanged.

Reviewed by Cursor Bugbot for commit b6cb839. Bugbot is set up for automated code reviews on this repo. Configure here.

@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@cursor review

@keelerm84 keelerm84 marked this pull request as ready for review April 13, 2026 14:55
@keelerm84 keelerm84 requested a review from a team as a code owner April 13, 2026 14:55
@devin-ai-integration devin-ai-integration Bot added the devin-pr PR created by Devin label Apr 13, 2026
@keelerm84 keelerm84 merged commit 49efcd4 into main Apr 13, 2026
13 checks passed
@keelerm84 keelerm84 deleted the mk/sdk-2164/bump-rand branch April 13, 2026 16:36
keelerm84 pushed a commit that referenced this pull request Apr 13, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.17.2](0.17.1...0.17.2)
(2026-04-13)


### Bug Fixes

* **deps:** bump rand from 0.8.5 to 0.10.1
([#129](#129))
([49efcd4](49efcd4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devin-pr PR created by Devin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants