feat: add custom parameters support for tools#125
Draft
tracisiebel wants to merge 4 commits intomainfrom
Draft
Conversation
Co-Authored-By: traci@launchdarkly.com <traci@launchdarkly.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: traci@launchdarkly.com <traci@launchdarkly.com>
…types Co-Authored-By: traci@launchdarkly.com <traci@launchdarkly.com>
devin-ai-integration
bot
changed the title
- Extract _get_tool_custom_parameter() helper to deduplicate across 4 classes - Extract _serialize_tool_custom_parameters() helper for to_dict serialization - Add ToolCustomParametersMap type alias for legibility - Only store tools that actually have customParameters (skip bare tool entries) - Add docstring on to_dict explaining completion-config serialization-path fallback - Add comment about dict insertion order in serialization helper Co-Authored-By: traci@launchdarkly.com <traci@launchdarkly.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Surfaces per-tool customParameters from AI config flag variations so application code can read dashboard-configured metadata at runtime without needing to hardcode tool behavior.
Adds tool_custom_parameters: Optional[ToolCustomParametersMap] field to AICompletionConfig, AICompletionConfigDefault, AIAgentConfig, and AIAgentConfigDefault
Adds get_tool_custom_parameter(tool_name, key) accessor on each config class
Parses customParameters from each tool entry in model.parameters.tools[] after flag evaluation; only tools with non-empty customParameters are included in the map
Agent configs fall back to default.tool_custom_parameters when the flag yields no tools; completion config defaults are carried through serialization into the evaluation fallback dict
Adds ToolCustomParametersMap type alias (exported from ldai) for use in application type annotations
Wire format uses customParameters (camelCase) matching the LaunchDarkly dashboard and API