Conversation
joker23
changed the title
joker23
force-pushed
the
skz/sdk-1958/react-vercel-example
branch
from
c38c86a to
f1c1dc9
Compare
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/browser size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/js-client-sdk-common size report |
joker23
force-pushed
the
skz/sdk-1958/react-vercel-example
branch
3 times, most recently
from
be9d2b4 to
58f5bd7
Compare
|
@cursor review |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
joker23
force-pushed
the
skz/sdk-1958/react-vercel-example
branch
from
58f5bd7 to
7379c64
Compare
This commit will also: - modify the server-only example to demonstrate how to use the isomorphic provider - modify the bundling so client and server can still bundle correcly with isomorphic components - refactor the client side NOOP client to be able to execute well during SSR
joker23
force-pushed
the
skz/sdk-1958/react-vercel-example
branch
from
7379c64 to
b0675b4
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b0675b4. Configure here.
| }, | ||
| "dependencies": { | ||
| "@launchdarkly/react-sdk": "0.1.1", | ||
| "@launchdarkly/vercel-server-sdk": "workspace:^", |
There was a problem hiding this comment.
Inconsistent dependency version strategy in package.json
Low Severity
The @launchdarkly/react-sdk dependency uses a pinned version "0.1.1" while @launchdarkly/vercel-server-sdk uses "workspace:^" in the same file. Both are workspace packages in this monorepo. When the react-sdk version bumps beyond 0.1.1, the pinned reference will fail to resolve to the local workspace package, potentially causing build failures or accidentally pulling a stale version from npm. Using workspace:^ for both workspace dependencies would keep them consistent and resilient to version changes.
Reviewed by Cursor Bugbot for commit b0675b4. Configure here.
There was a problem hiding this comment.
I agree we should be consistent, but also that we should use the opposite of the strategy recommended here.
joker23
force-pushed
the
skz/sdk-1958/react-vercel-example
branch
from
b0675b4 to
26b0092
Compare
2 participants
This PR will add a vercel edge example showcasing that our Next.js integration is compatible with the edge sdk (in fact it is almost identical to the nodejs version)
Caveat
I did not implement CI for this just yet. Still pending further discussions to properly set things up.
Alternative
This example might be able to replace the
completeexample we made forvercelsdk.Note
Low Risk
Mostly adds a new example app and wiring in workspace/release config; low blast radius outside docs/tooling. Risk is limited to potential dependency/version drift in the new example and release-please extra-files tracking.
Overview
Adds a new
packages/sdk/react/examples/vercel-edgeNext.js App Router example demonstrating flag evaluation via@launchdarkly/vercel-server-sdk+ Vercel Edge Config, with server-sidecreateLDServerSession/useLDServerSessionand client bootstrap throughLDIsomorphicProvider.Updates the monorepo to include the example in Yarn workspaces, documents it in the React examples README, adds a basic Playwright e2e check, and extends
release-please-config.jsonto keep the example’s@launchdarkly/react-sdkand@launchdarkly/vercel-server-sdkdependency pins in sync.Reviewed by Cursor Bugbot for commit 26b0092. Bugbot is set up for automated code reviews on this repo. Configure here.