Skip to content

Add a SpinerEosDependsRhoSie constructor that uses an existing eos object to generate a spiner eos#632

Open
buechlerm wants to merge 4 commits intomainfrom
buechler/spiner_constructor
Open

Add a SpinerEosDependsRhoSie constructor that uses an existing eos object to generate a spiner eos#632
buechlerm wants to merge 4 commits intomainfrom
buechler/spiner_constructor

Conversation

@buechlerm
Copy link
Copy Markdown
Collaborator

PR Summary

This is currently very DRAFy. Almost completely generated by AI and I haven't fully reviewed the work myself, so if you don't have time to look at it right now, that's fine.

I had asked it to emulate sesame2spiner in terms of parameters for grid generation. Seems somewhat heavyweight, but there are defaults.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@buechlerm buechlerm self-assigned this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants