fix: clear Dependabot security alerts via direct bumps and overrides - #490
Closed
AaronFeledy wants to merge 8 commits into
Closed
fix: clear Dependabot security alerts via direct bumps and overrides#490AaronFeledy wants to merge 8 commits into
AaronFeledy wants to merge 8 commits into
Conversation
Bumps [tar](https://github.com/isaacs/node-tar) to 7.5.9 and updates ancestor dependencies [tar](https://github.com/isaacs/node-tar), [@npmcli/arborist](https://github.com/npm/cli/tree/HEAD/workspaces/arborist), [npm-profile](https://github.com/npm/npm-profile) and [pacote](https://github.com/npm/pacote). These dependencies need to be updated together. Updates `tar` from 6.2.1 to 7.5.9 - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.2.1...v7.5.9) Updates `@npmcli/arborist` from 6.5.1 to 9.3.0 - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/workspaces/arborist/CHANGELOG.md) - [Commits](https://github.com/npm/cli/commits/v9.3.0/workspaces/arborist) Updates `npm-profile` from 9.0.2 to 12.0.1 - [Release notes](https://github.com/npm/npm-profile/releases) - [Changelog](https://github.com/npm/npm-profile/blob/main/CHANGELOG.md) - [Commits](npm/npm-profile@v9.0.2...v12.0.1) Updates `pacote` from 15.2.0 to 21.3.1 - [Release notes](https://github.com/npm/pacote/releases) - [Changelog](https://github.com/npm/pacote/blob/main/CHANGELOG.md) - [Commits](npm/pacote@v15.2.0...v21.3.1) --- updated-dependencies: - dependency-name: tar dependency-version: 7.5.9 dependency-type: indirect - dependency-name: "@npmcli/arborist" dependency-version: 9.3.0 dependency-type: direct:production - dependency-name: npm-profile dependency-version: 12.0.1 dependency-type: direct:production - dependency-name: pacote dependency-version: 21.3.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Regenerate package-lock after rebase onto main and override tar to ^7.5.22 so the critical/high node-tar advisories are actually cleared (not left on 7.5.9).
❌ Deploy Preview for lando-core failed. Why did it fail? →
|
Bump direct runtime deps to patched floors (axios, js-yaml, lodash, nanoid, node-forge) and add npm overrides for sticky transitive advisories (tar, undici, brace-expansion, form-data, etc.). Use version-targeted minimatch overrides so mocha/glob keep working. Also refresh Fastify example lockfiles for fast-uri / find-my-way. Deferred: yargs-parser major, glob major, octokit major, vite/esbuild dev-server advisories.
Blanket overrides forced consumers across major boundaries: picomatch was pulled 4.0.3 -> 2.3.2 (breaking @yao-pkg/pkg and tinyglobby, both of which need ^4), brace-expansion pushed minimatch 3.x consumers from 1.x to 2.x, and nanoid left vitepress resolving an "invalid" 5.1.16 against a ^3.3.17 override. Use version-targeted overrides so each major line lands on its own patched floor, and raise the tmp floor to ^0.2.6 to match the advisory.
Running npm test on Node 24 crashes in mocha's nested glob 7.2.0 before any test executes, which reads like a real failure. Record the cause and the shell-globstar workaround.
AaronFeledy
force-pushed
the
fix/security-deps-2026-08
branch
from
August 10, 2026 02:26
6c427ff to
1c12e2c
Compare
Member
Author
|
Closing as superseded/conflicting. #457 already merged the security dep work onto main ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears the remaining Dependabot security alert classes on
lando/corewithout any drive-by majors that need real API work.Stacked on #457 (npm tooling majors +
taroverride). Merge that first — this branch contains its commits, so the diff will shrink to just this work once #457 lands.Direct runtime dep bumps
axios^1.5.1^1.18.0js-yaml^4.1.0^4.3.1lodash^4.17.21^4.18.0nanoid^3^3.3.17node-forge^1.3.1^1.4.0All stay within their existing major, so no code changes needed.
Overrides for sticky transitives
These advisories sit in packages we don't depend on directly, so a range bump alone won't move them. Each is pinned to its patched floor:
tar^7.5.22·undici^6.28.0·form-data^4.0.6·fast-uri^3.1.5·follow-redirects^1.16.0·flatted^3.4.2·immutable^5.1.8·postcss^8.5.23·ip-address^10.3.1·serialize-javascript^7.0.5·tmp^0.2.6·lodash-es^4.18.0Version-targeted where multiple majors coexist in the tree, so nothing gets dragged across a major boundary:
minimatch@33.1.5,@44.2.5,@55.1.9,@88.0.7,@99.0.9brace-expansion@1^1.1.18,@2^2.1.4picomatch@2^2.3.2,@4^4.0.4nanoid@3^3.3.17,@5^5.1.6The targeting matters: a blanket
picomatchoverride downgrades@yao-pkg/pkgandtinyglobbyfrom 4.x to 2.x (which would breaknpm run pkg), and a blanketbrace-expansionpushes everyminimatch3.x consumer onto 2.x.Example lockfiles
examples/command,examples/entrypoint,examples/mounts:fast-uri3.1.2 → 3.1.5 andfind-my-way9.6.0 → 9.7.0, pinned as direct deps (same approach as #482). All three stillnpm ciclean.Cross-major overrides, verified
Three overrides cross a major boundary. All are CJS and were smoke-tested against their actual consumers:
tmp0.0.33 → 0.2.7 (external-editor) —tmp.fileSync()still returns{name, removeCallback}ip-address9.0.5 → 10.4.0 (socks) —Address4/Address6construct and format correctlyserialize-javascript6.0.0 → 7.1.0 (mocha, dev-only) —serialize()output unchanged; needs Node >=20, which the new engine floor satisfiesDocs
CHANGELOG.mdentries for the direct bumps and the overridesAGENTS.md: noted thatnpm teston Node 24 dies insidemocha's nestedglob7.2.0 withTypeError: Cannot convert a Symbol value to a stringbefore any test runs. Pre-existing onmain, not caused by this PR, but it reads like a real test failure and cost time to diagnose.Testing
npm lsreports no invalid or unmet resolutionsnpm ci --dry-runIntentionally deferred
yargs-parsermajor andglobmajor — compatibility risk, parked deliberately@octokit/rest^19 → ^22 — three moderate ReDoS alerts, but it's a major with real API churnmocha/nycmajors (diff,uuidalerts) — dev-onlyvite/esbuilddev-server alerts — high severity but dev-only viavitepress, andnpm auditreports no fix available without a vitepress majorRemaining
npm auditafter this PR: 18 (1 high, 14 moderate, 3 low), all in the deferred list above and none in shipped runtime code.