fix(lance-io): reject malformed message length prefix in read_message_from_buf - #9070
Open
foobar wants to merge 1 commit into
Open
fix(lance-io): reject malformed message length prefix in read_message_from_buf#9070foobar wants to merge 1 commit into
foobar wants to merge 1 commit into
Conversation
github-actions
Bot
added
A-encoding
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-changes
foobar
force-pushed
the
fix/read-message-from-buf-bounds
branch
from
September 9, 2026 06:44
f65308f to
1013731
Compare
lance-gatekeeper
Bot
removed
the
K-changes
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-changes
…_from_buf A file-controlled u32 prefix could slice past the buffer and panic the process; return an error instead.
foobar
force-pushed
the
fix/read-message-from-buf-bounds
branch
from
September 9, 2026 11:57
1013731 to
c344da1
Compare
lance-gatekeeper
Bot
removed
the
K-changes
lance-gatekeeper
Bot
added
the
K-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read_message_from_bufsliced its input with a file-controlled u32 length prefix without bounds checks, so a crafted v1 file, index, or manifest tail panicked the process on open/scan. Mirrors the checks the asyncread_messagealready performs.Test plan
test_read_message_from_buf_rejects_malformed_length_prefixcovers the sub-prefix and oversized-prefix cases (both panicked before);cargo test -p lance-io --lib utils::tests, fmt, and clippy-D warningsall clean.