fix(substrait): detect unsupported fixed-size-list filters - #9057
Open
lance-gatefixer[bot] wants to merge 1 commit into
Open
fix(substrait): detect unsupported fixed-size-list filters#9057lance-gatefixer[bot] wants to merge 1 commit into
lance-gatefixer[bot] wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The change establishes the capability boundary before schema pruning, so filters that reference unsupported fixed-size-list fields return NotSupported while supported predicates on vector-bearing datasets continue to round-trip. Option and precomputed-plan filters are both covered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
FilteredReadExec pruned FixedSizeList fields before DataFusion type-checked its filter expressions. A valid predicate referencing a pruned vector field therefore surfaced as FieldNotFound instead of an unsupported Substrait transport.
Fix
Add a reusable expression preflight against the original schema and apply it to options and precomputed-plan filters before pruning. FixedSizeList references now return a typed NotSupported error so distributed callers can retain the predicate on another execution path; filters referencing supported fields around an unreferenced vector continue to round-trip.
Validation
Fixes #9056