Skip to content

fix(substrait): detect unsupported fixed-size-list filters - #9057

Open
lance-gatefixer[bot] wants to merge 1 commit into
mainfrom
gatekeeper/fix-9056-1
Open

fix(substrait): detect unsupported fixed-size-list filters#9057
lance-gatefixer[bot] wants to merge 1 commit into
mainfrom
gatekeeper/fix-9056-1

Conversation

@lance-gatefixer

Copy link
Copy Markdown
Contributor

Root cause

FilteredReadExec pruned FixedSizeList fields before DataFusion type-checked its filter expressions. A valid predicate referencing a pruned vector field therefore surfaced as FieldNotFound instead of an unsupported Substrait transport.

Fix

Add a reusable expression preflight against the original schema and apply it to options and precomputed-plan filters before pruning. FixedSizeList references now return a typed NotSupported error so distributed callers can retain the predicate on another execution path; filters referencing supported fields around an unreferenced vector continue to round-trip.

Validation

  • cargo test -p lance-datafusion --features substrait --lib substrait::tests
  • cargo test -p lance --features substrait --lib io::exec::filtered_read_proto::tests
  • cargo test -p lance-datafusion --features substrait --doc
  • cargo fmt --all -- --check
  • cargo clippy --all --tests --benches -- -D warnings

Fixes #9056

@github-actions github-actions Bot added the bug Something isn't working label Sep 8, 2026

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gate recommendation: approve.

The change establishes the capability boundary before schema pruning, so filters that reference unsupported fixed-size-list fields return NotSupported while supported predicates on vector-bearing datasets continue to round-trip. Option and precomputed-plan filters are both covered.

@lance-gatekeeper lance-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working K-approved Latest Gatekeeper recommendation permits acceptance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Substrait expression transport cannot encode predicates on FixedSizeList columns

0 participants