docs: correct stable row ID migration and storage - #8852
Conversation
|
Important Format specification voteThis PR modifies the Lance format specification, so it requires 3 binding +1 votes from PMC members (excluding the proposer) and a minimum 72-hour voting period, weekends excluded, before it can merge. Vote by approving this PR (+1) or requesting changes (−1, a veto). See the voting process. Status: ❌ Blocked — 0 of 3 required approvals
Updated automatically by the format-spec vote gate, which re-checks every 15 minutes — just voted? Re-check now (press Run workflow; leave the input blank to re-check every open format PR). A PMC member may apply the |
|
Blocked: the current head cannot pass Remote head |
|
Blocked: the current head cannot pass Remote head |
|
Blocked: the current head is held by an unrelated Windows runner failure and the required format-spec approval gate. Remote head |
|
Blocked: the current head remains held by an unrelated Windows hosted-runner failure and the required format-spec approval gate. Remote head |
|
Blocked: the current head cannot satisfy Remote head |
|
Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes. Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33217104161 and reports 0/3 PMC approvals on this commit; its evaluator job 99003082863 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes. Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33218990261 and reports 0/3 PMC approvals on this commit; its evaluator job 99008845859 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes. Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33219934264 and reports 0/3 PMC approvals on this commit; its evaluator job 99011652281 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes. Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33220685156 and reports 0/3 PMC approvals on this commit; its evaluator job 99013887195 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: the current head cannot satisfy Remote head |
|
Blocked: the current head cannot satisfy Remote head |
|
Blocked: PR #8852 cannot merge because the required The current To unblock the PR, three PMC members must approve this exact commit under the format-spec vote process, after which the evaluator can update the status. As a practical alternative, maintainers can revise or supersede the format-spec proposal through the normal governance process and provide the resulting concrete direction for the FixAgent. |
|
Blocked: PR #8852 cannot merge because the required The current To unblock the PR, three PMC members must approve this exact commit under the format-spec vote process, after which the evaluator can update the status. As a practical alternative, maintainers can revise or supersede the format-spec proposal through the normal governance process and provide the resulting concrete direction for the FixAgent. |
|
Blocked: PR #8852 cannot merge because the required The current To unblock the PR, three PMC members must approve this exact commit under the format-spec vote process, after which the evaluator can update the status. As a practical alternative, maintainers can revise or supersede the format-spec proposal through the normal governance process and provide the resulting concrete direction for the FixAgent. |
|
Blocked: PR #8852 cannot merge because the required The current Attempted: fetched and verified both refs and the exact Ready PR identity, inspected the live issue, reviews, inline comments, PR conversation, current status, CheckRuns, and evaluator log, compiled The smallest next action is for three eligible PMC members to provide binding approvals on this exact commit and let the vote gate re-evaluate. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 cannot merge because the required The current Attempted: fetched and verified both refs and the exact Ready PR identity, inspected the live issue, reviews, inline comments, full PR conversation, current status, CheckRuns, and evaluator log, compiled the protobuf schema, built the documentation successfully with existing warnings, checked the branch diff for whitespace errors, and confirmed a normal same-branch push was already up to date. No attributable repository failure remains to repair. The smallest next action is for three eligible PMC members to provide binding approvals on this exact commit and let the vote gate re-evaluate. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 cannot merge because the required The current Attempted: fetched and verified both refs and the exact Ready PR identity, inspected the live issue, reviews, inline comments, full PR conversation, current status, CheckRuns, and evaluator log, compiled the protobuf schema, built the documentation successfully with existing warnings, checked the branch diff for whitespace errors, and confirmed a normal same-branch push was already up to date. No attributable repository failure remains to repair. The smallest next action is for three eligible PMC members to provide binding approvals on this exact commit and let the vote gate re-evaluate. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 cannot merge because the required The current Attempted: fetched and verified both refs and the exact Ready PR identity, inspected the live issue, reviews, inline comments, full PR conversation, current status, CheckRuns, and evaluator log, compiled the protobuf schema, built the documentation successfully with existing warnings, checked the branch diff for whitespace errors, and confirmed a normal same-branch push was already up to date. No attributable repository failure remains to repair. The smallest next action is for three eligible PMC members to provide binding approvals on this exact commit and let the vote gate re-evaluate. Alternatively, a PMC member may apply |
|
Blocked: the current head cannot satisfy Remote head |
|
Blocked: the current head cannot satisfy Remote head |
|
Blocked: the current head cannot satisfy Remote head |
|
Blocked: the current head cannot satisfy Remote head |
|
Blocked: PR #8852 cannot merge because the required The current The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and let the vote gate re-evaluate. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 cannot merge because the required The current The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and let the vote gate re-evaluate. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 cannot merge because the required The current The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and let the vote gate re-evaluate. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 cannot merge because the required The current The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit and let the vote gate re-evaluate. Alternatively, a PMC member may apply |
|
Blocked: PR #8852 cannot merge because the required format-spec-vote status on remote head 3d9497d reports 0/3 PMC approvals on this commit. Remote head 3d9497d contains the current main tip 31d78d1. All 34 current-head CheckRuns pass; the failing commit status targets Actions run 34575950370 and evaluator job 103188316327, both completed successfully, and the job log explicitly reports PR #8852: 0/3 PMC approvals on this commit. I fetched and verified base ancestry and remote identity, reviewed the live issue, PR, reviews, threads, checks, and logs, reran protobuf compilation, the documentation build, and diff validation, and pushed the assigned branch normally; no attributable repository defect remains. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this commit. Alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: PR #8852 cannot merge because the required format-spec-vote status on remote head 3d9497d reports 0/3 PMC approvals on this commit. Remote head 3d9497d contains the current main tip 31d78d1. All 34 current-head CheckRuns pass; the failing commit status targets Actions run 34581034632 and evaluator job 103204375808, both completed successfully, and the job log explicitly reports PR #8852: 0/3 PMC approvals on this commit. I fetched and verified base ancestry and remote identity, reviewed the live issue, PR, reviews, threads, checks, and logs, reran protobuf compilation, the documentation build, and diff validation, and pushed the assigned branch normally; no attributable repository defect remains. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this commit. Alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: PR #8852 remains blocked by an unrelated Windows hosted-runner file-access failure and the required format-spec approval gate. Remote head f83166a contains the current main tip e89ceb3. The windows-build Check in Actions run 34584199097, job 103214490907, failed only lance::index::vector::ivf::tests::test_create_ivf_hnsw_pq because persisting a runner temporary shuffle_data.lance file returned Access is denied (os error 5); the identical test passed on exact-base Windows job 103213450797, and this branch changes only format documentation and protobuf comments. Separately, the format-spec-vote status targets run 34585889195, whose evaluator job 103219877434 completed successfully while logging PR #8852: 0/3 PMC approvals on this commit. I fetched both refs, verified base ancestry and the exact Ready PR identity, inspected the current-head and exact-base logs and the full PR conversation, compiled the protobuf schema, built the documentation, checked the diff, and pushed the assigned branch normally; it is up to date and no attributable repository defect remains. The smallest next actions are to rerun windows-build on a clean hosted runner and obtain three binding +1 PMC approvals on this exact commit. Practical alternatives are to rerun the full Rust workflow and, if this documentation correction qualifies as trivial, have a PMC member apply format-waived. |
|
Blocked: PR #8852 remains blocked by an unrelated Windows hosted-runner file-access failure and the required format-spec approval gate. Remote head f83166a contains the current main tip e89ceb3. The windows-build Check in Actions run 34584199097, job 103214490907, failed only lance::index::vector::ivf::tests::test_create_ivf_hnsw_pq because persisting a runner temporary shuffle_data.lance file returned Access is denied (os error 5); the identical test passed on exact-base Windows job 103213450797, and this branch changes only format documentation and protobuf comments. Separately, the format-spec-vote status targets run 34587175451, whose evaluator completed successfully while logging PR #8852: 0/3 PMC approvals on this commit. I fetched both refs, verified base ancestry and the exact Ready PR identity, inspected the current-head and exact-base logs and the full PR conversation, compiled the protobuf schema, built the documentation, checked the diff, and pushed the assigned branch normally; it is up to date and no attributable repository defect remains. The smallest next actions are to rerun windows-build on a clean hosted runner and obtain three binding +1 PMC approvals on this exact commit. Practical alternatives are to rerun the full Rust workflow and, if this documentation correction qualifies as trivial, have a PMC member apply format-waived. |
|
Blocked: PR #8852 remains blocked by an unrelated Windows hosted-runner file-access failure and the required format-spec approval gate. Remote head f83166a contains the current main tip e89ceb3. The windows-build Check in Actions run 34584199097, job 103214490907, failed only lance::index::vector::ivf::tests::test_create_ivf_hnsw_pq because persisting a runner temporary shuffle_data.lance file returned Access is denied (os error 5); the identical test passed on exact-base Windows job 103213450797, and this branch changes only format documentation and protobuf comments. Separately, the format-spec-vote status targets run 34589021421, whose evaluator completed successfully while logging PR #8852: 0/3 PMC approvals on this commit. I fetched both refs, verified base ancestry and the exact Ready PR identity, inspected the current-head and exact-base logs and the full PR conversation, compiled the protobuf schema, built the documentation, checked the diff, and pushed the assigned branch normally; it is up to date and no attributable repository defect remains. The smallest next actions are to rerun windows-build on a clean hosted runner and obtain three binding +1 PMC approvals on this exact commit. Practical alternatives are to rerun the full Rust workflow and, if this documentation correction qualifies as trivial, have a PMC member apply format-waived. |
|
Blocked: PR #8852 remains blocked by an unrelated Windows hosted-runner file-access failure and the required format-spec approval gate. Remote head f83166a contains the current main tip e89ceb3. The windows-build Check in Actions run 34584199097, job 103214490907, failed only lance::index::vector::ivf::tests::test_create_ivf_hnsw_pq because persisting a runner temporary shuffle_data.lance file returned Access is denied (os error 5); the identical test passed on exact-base Windows job 103213450797, and this branch changes only format documentation and protobuf comments. Separately, the format-spec-vote status targets run 34589767488, whose evaluator completed successfully while logging PR #8852: 0/3 PMC approvals on this commit. I fetched both refs, verified base ancestry and the exact Ready PR identity, inspected the current-head and exact-base logs and the full PR conversation, compiled the protobuf schema, built the documentation, checked the diff, and pushed the assigned branch normally; it is up to date and no attributable repository defect remains. The smallest next actions are to rerun windows-build on a clean hosted runner and obtain three binding +1 PMC approvals on this exact commit. Practical alternatives are to rerun the full Rust workflow and, if this documentation correction qualifies as trivial, have a PMC member apply format-waived. |
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The pull-request patch remains unchanged. The new base commit only changes scheduling and coverage for already-bounded blob reads; it does not alter stable-row-ID migration, index coordination, physical-row accounting, or row/version-sequence storage. The corrected migration and storage guidance remains accurate.
|
Blocked: PR #8852 cannot merge because the required format-spec-vote status on remote head d1a4c72 reports 0/3 PMC approvals on this commit. Remote head d1a4c72 contains the current main tip 1b90368. The live PR rollup has 32 passing checks and only format-spec-vote failing; its status targets Actions run 34593624029, and evaluator job 103244286807 completed successfully while logging PR #8852: 0/3 PMC approvals on this commit. I fetched both refs, verified base ancestry and Ready PR identity, read the live issue, PR, reviews, threads, full conversation, checks, and evaluator logs, and reran protobuf compilation, the documentation build, and diff validation. No attributable repository defect remains, so no speculative code change or push was made. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit. Alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: PR #8852 cannot merge because the required format-spec-vote status on remote head d1a4c72 reports 0/3 PMC approvals on this commit. Remote head d1a4c72 contains the current main tip 1b90368. The live PR rollup has 32 passing checks and only format-spec-vote failing; its status targets Actions run 34594414646, and evaluator job 103246737159 completed successfully while logging PR #8852: 0/3 PMC approvals on this commit. I fetched both refs, verified base ancestry and Ready PR identity, read the live issue, PR, reviews, threads, full conversation, checks, and evaluator logs, and reran protobuf compilation, the documentation build, and diff validation. No attributable repository defect remains, so no speculative code change or push was made. The smallest next action is for three eligible PMC members to provide binding +1 approvals on this exact commit. Alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
Summary
Root cause
The format documentation and protobuf comments still described pre-implementation plans: they said existing datasets could not migrate and presented a 200 KB inline/external threshold as active writer behavior. Migration has since shipped, but writers still emit every sequence inline and readers cannot load external version sequences.
Validation
protoc --proto_path=../protos --descriptor_set_out=/dev/null ../protos/table.protouv run mkdocs build(completed with pre-existing missing-link warnings outside this change)git diff --checkFixes #8851