[Copilot]

Default delaying and rate-limiting queues leave executor threads alive after shutdown, potentially preventing JVM termination. Waiting tasks can also remain blocked until a distant delayed-item deadline.

• Lifecycle: Retain and cancel the waiting task on shutdown; terminate internally owned executors.
• Ownership: Preserve caller-supplied executors for unrelated work and document that contract. Route controller-created queues through the owning constructor.
• Regression coverage: Add bounded checks for executor termination, distant deadlines, repeated shutdown, queued-task cancellation, shared-executor usability, and controller shutdown/replacement.

• Fixes Terminate internally owned delaying-queue executors on shutdown #4977

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: brendandburns / name: Brendan Burns (684e3d4, c804d04, d78659c)

[brendandburns]

I'm worried that this will break if the tests run in parallel. Instead of making it a member variable in the Test class, enqueue each one in a list, and tear down all of them within the teardown method.

[brendandburns]

@copilot please address comment

[Copilot]

@copilot please address comment

Addressed in 93ba21e: each delaying queue test now creates its own local queue, registers it in a thread-safe list, and teardown shuts down every registered queue. All 18 targeted tests pass with parallel execution enabled.

[brendandburns]

Same comment as above, this makes these tests not work when run in parallel. I realize that for now there is only one test, but this will be a gotcha whenever someone adds an additional test. Please move this back into the test method and add it to a queue for teardown at the end of the tests.

[brendandburns]

@copilot please address comment and make sure CI/CD is passing

[Copilot]

@copilot please address comment and make sure CI/CD is passing

Addressed in 9037d0a: the rate-limiting queue and executor are method-local and registered in thread-safe teardown lists. All 18 targeted tests pass with parallel execution enabled. CI for this commit is blocked: Bazel, Spotless, and CodeQL report action_required, and EasyCLA reports missing CLA authorization. Please approve the workflow runs and resolve the CLA authorization so CI can run. Local Spotless remains blocked by the Groovy formatter download’s HTTP 403.

[brendandburns]

/lgtm
/approve

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, Copilot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment