Skip to content

Cert manager fix#4627

Open
adithyanms-debug wants to merge 4 commits intokubernetes-client:masterfrom
adithyanms-debug:cert-manager-fix
Open

Cert manager fix#4627
adithyanms-debug wants to merge 4 commits intokubernetes-client:masterfrom
adithyanms-debug:cert-manager-fix

Conversation

@adithyanms-debug
Copy link

This PR fixes the update.sh script in the client-java-contrib/cert-manager
module which was broken due to two issues found while attempting to regenerate
the cert-manager CRD model classes locally.

Problems Found

1. Broken Docker Registry

The script was pointing to docker.pkg.github.com which is the old GitHub
Packages registry that requires authentication even for public images.

This caused the following error when running update.sh:

Unable to find image 'docker.pkg.github.com/kubernetes-client/java/crd-model-gen:v2.0.0' locally
docker: Error response from daemon: Head "https://docker.pkg.github.com/v2/
kubernetes-client/java/crd-model-gen/manifests/v2.0.0": no basic auth credentials.

GitHub migrated public container images to ghcr.io which does not require
authentication for public images.

2. Outdated GitHub Org in CRD URL

The CRD download URL was still using jetstack/cert-manager which is the old
org name. The cert-manager project moved to the cert-manager/cert-manager org
in v1.8. While GitHub currently redirects the old URL, relying on redirects is
fragile and should not be depended upon.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adithyanms-debug
Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 1, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: adithyanms-debug / name: adithyanms-debug (81546bf, a710886)

@k8s-ci-robot
Copy link
Contributor

Welcome @adithyanms-debug!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 1, 2026
@adithyanms-debug
Copy link
Author

I am new to open source. Forgive me if i am wrong

@ViliusS
Copy link

ViliusS commented Mar 2, 2026

This PR is an AI slop.

@brendandburns
Copy link
Contributor

Can you revert all of the unrelated changes to mvnw, then I think this is good to merge.

@adithyanms-debug
Copy link
Author

@brendandburns do i need to revert the mnvw in the root directory. I think i didn't make any change over there, and sorry if the code is a slope. Will make it better next time : )

@brendandburns
Copy link
Contributor

If you look here:
https://github.com/kubernetes-client/java/pull/4627/changes

There are lots of mvnw related changes, I suspect it is just a difference between your environment and ours.

Thanks!

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 4, 2026
@adithyanms-debug
Copy link
Author

Reverted the mvnw changes

@brendandburns
Copy link
Contributor

There's also a bunch of file mode changes 100755 -> 100655 which means that the scripts aren't executable, can you revert those changes also?

Thanks

@adithyanms-debug
Copy link
Author

Made the changes. Please let me know if there are any error

Thanks!!

@brendandburns
Copy link
Contributor

image

I still see the file mode changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants