Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adithyanms-debug The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @adithyanms-debug! |
|
I am new to open source. Forgive me if i am wrong |
|
This PR is an AI slop. |
|
Can you revert all of the unrelated changes to |
|
@brendandburns do i need to revert the mnvw in the root directory. I think i didn't make any change over there, and sorry if the code is a slope. Will make it better next time : ) |
|
If you look here: There are lots of mvnw related changes, I suspect it is just a difference between your environment and ours. Thanks! |
|
Reverted the mvnw changes |
|
There's also a bunch of file mode changes Thanks |
|
Made the changes. Please let me know if there are any error Thanks!! |

This PR fixes the
update.shscript in theclient-java-contrib/cert-managermodule which was broken due to two issues found while attempting to regenerate
the cert-manager CRD model classes locally.
Problems Found
1. Broken Docker Registry
The script was pointing to
docker.pkg.github.comwhich is the old GitHubPackages registry that requires authentication even for public images.
This caused the following error when running
update.sh:GitHub migrated public container images to
ghcr.iowhich does not requireauthentication for public images.
2. Outdated GitHub Org in CRD URL
The CRD download URL was still using
jetstack/cert-managerwhich is the oldorg name. The cert-manager project moved to the
cert-manager/cert-managerorgin v1.8. While GitHub currently redirects the old URL, relying on redirects is
fragile and should not be depended upon.