Harden Distances input and output handling - #93
Closed
krotname wants to merge 1 commit into
Closed
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
output.txtand unbounded array allocation from attacker-controlled input by removing fixed-path file I/O and validating sizes.Description
new FileInputStream("input.txt")/new FileOutputStream("output.txt")usage by addingrun(InputStream, OutputStream)and delegating the no-argrun()torun(System.in, System.out)so callers supply streams.private static final int MAX_INPUT_SIZE = 100_000and validatenwithif (n < 1 || n > MAX_INPUT_SIZE)to reject negative, zero, or excessive sizes before allocating theint[].flush()fromFastOut.flush().src/test/java/algorithms/sprint1/DistancesTest.javafor normal stream I/O and invalid sizes, and updatedAlgorithmCliTestto exerciseDistances.runvia standard I/O instead of contest files.Testing
git diff --checkwith no reported whitespace problems.mvn -q -Dtest=algorithms.sprint1.DistancesTest test, which passed the new unit tests.mvn -q verify, and the full test suite completed successfully (integration and unit tests passed; Maven emitted only a non-failing JDK/deprecation warning).Codex Task