Handle malformed RPN calculator input safely - #91
Closed
krotname wants to merge 1 commit into
Closed
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Calculatorpreviously assumed well-formed RPN tokens and performed unchecked stack pops, division, and integer parsing which allowed malformed stdin (e.g.+, empty input,1 0 /,abc, or extra operands) to throw runtime exceptions and terminate the process. The change prevents these crash/availability paths by validating untrusted input.Description
st.size() < 2and reject with a controlled error instead of performing uncheckedpop()calls ineval(src/main/java/algorithms/sprint2/Calculator.java).Math.floorDivand reject with a clear error message.parseIntin a try/catch and rethrowing asIllegalArgumentException, and require the final stack size to be exactly one before returning the result.IllegalArgumentExceptionat the CLI boundary inrun()by printing a short diagnostic tostderrand returning instead of allowing stack/parse/arithmetic exceptions to propagate.src/test/java/algorithms/AlgorithmCliTest.javathat verifies theCalculatorrejects+, empty input,1 0 /,abc, and an extra-operand case.Testing
mvn -q -Dtest=algorithms.AlgorithmCliTest testand the test suite for the modified integration case completed successfully.mvn -q testto execute the full test suite and it completed without failures.mvn -q checkstyle:checkand code passes the project's checkstyle rules.git diff --checkto ensure no whitespace or patch issues and it reported clean results.Codex Task