Harden Solution2 stdin handling - #89
Closed
krotname wants to merge 1 commit into
Closed
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation
NullPointerExceptionwhen the declared stdin line count does not match supplied input.StringBuilder, which can lead to OOM for attacker-controlled large input.Description
MAX_LINE_COUNTlimit andreadLineCount,readInputLine, andnextTokenhelpers to validate the declared line count, EOF, and token availability insrc/main/java/algorithms/sprint1/Solution2.java.PrintWriterto eliminate unboundedStringBuildergrowth and preserved the expected trailing blank line.Math.addExactfor safer arithmetic, and throwIllegalArgumentExceptionon malformed input.src/test/java/algorithms/AlgorithmCliTest.javato assert that missing input lines and oversized line counts are rejected.Testing
mvn -q -Dtest=AlgorithmCliTest test, which passed after the fix.mvn -q test, which completed successfully.mvn -q verify, which completed successfully and includes the new integration checks forSolution2.Codex Task