Prevent PigLatin crashes on empty whitespace tokens - #113
Closed
krotname wants to merge 1 commit into
Closed
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
kyu5.PigLatin.pigItwhere splitting on whitespace can produce empty tokens that reachsubstring(1)/charAt(0)and throwStringIndexOutOfBoundsExceptionfor empty input, leading spaces, or consecutive spaces.Description
src/main/java/kyu5/PigLatin.javawithif (w.isEmpty()) continue;before performing the Pig Latin transformation.!w.matches("\\W")branch and appending punctuation tokens unchanged.handlesEmptyTokensWithoutThrowinginsrc/test/java/kyu5/PigLatinTest.javathat covers empty input, leading whitespace, and consecutive whitespace.Handle empty Pig Latin tokens safely.Testing
mvn -q -Dtest=PigLatinTest testand the PigLatin test passed successfully.mvn -q testand the full test suite passed successfully.mvn -q verifyand verification (including checks) completed successfully.git diff --checkand workspace status checks showed no issues.Codex Task