Skip to content

Prevent regex metacharacter crashes in CamelCase.toCamelCase #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krotname wants to merge 1 commit into from
Closed

Prevent regex metacharacter crashes in CamelCase.toCamelCase #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/kyu6/CamelCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,10 @@ public static String fromCamelCase(String input) {
}

public static String toCamelCase(String str) {
if (str == null || str.isEmpty()) return "";
return Arrays.stream(str.split(" "))
.filter(s -> s.length() > 0)
.map(s -> s.replaceFirst(s.substring(0, 1), s.substring(0, 1).toUpperCase(Locale.ROOT)))
.map(s -> s.substring(0, 1).toUpperCase(Locale.ROOT) + s.substring(1))
.collect(Collectors.joining()).trim();
}

Expand Down
10 changes: 10 additions & 0 deletions src/test/java/kyu6/CamelCaseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,14 @@ public class CamelCaseTest {
void smokeTestsShouldExecuteApi() {
quality.SmokeMethodTestHarness.verify(kyu6.CamelCase.class);
}

@Test
void toCamelCaseShouldTreatRegexCharactersLiterally() {
assertEquals("[abc?def\\ghi$there", kyu6.CamelCase.toCamelCase("[abc ?def \\ghi $there"));
}

@Test
void toCamelCaseShouldHandleNullInput() {
assertEquals("", kyu6.CamelCase.toCamelCase(null));
}
}