Skip to content

feat(list): add replica count - #4011

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
pmeida:feat/func-list-replica-count
Aug 19, 2026
Merged

feat(list): add replica count#4011
knative-prow[bot] merged 1 commit into
knative:mainfrom
pmeida:feat/func-list-replica-count

Conversation

@pmeida

@pmeida pmeida commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

  • Add REPLICAS column to func list output - each deployer backend (k8s, keda, knative) populates a Replicas field on ListItem from the live deployment state

/kind enhancement

Fixes #4004

Release Note

`func list` now shows a `REPLICAS` column indicating how many ready instances of each deployed function are currently running.

Docs

@knative-prow knative-prow Bot added do-not-merge/work-in-progress 🤖 PR should not merge because it is a work in progress. kind/enhancement Feature additions or improvements to existing labels Aug 14, 2026
@knative-prow-robot knative-prow-robot added the needs-rebase Cannot be merged due to conflicts with HEAD. label Aug 14, 2026
@knative-prow knative-prow Bot added size/L 🤖 PR changes 100-499 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels Aug 14, 2026
@knative-prow

knative-prow Bot commented Aug 14, 2026

Copy link
Copy Markdown

Hi @pmeida. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pmeida pmeida changed the title Add replica count to func list output feat(list): add replica count Aug 14, 2026
@pmeida
pmeida force-pushed the feat/func-list-replica-count branch from c3889fe to 20af44d Compare August 14, 2026 15:09
@knative-prow-robot knative-prow-robot removed the needs-rebase Cannot be merged due to conflicts with HEAD. label Aug 14, 2026
@knative-prow knative-prow Bot added size/M 🤖 PR changes 30-99 lines, ignoring generated files. and removed size/L 🤖 PR changes 100-499 lines, ignoring generated files. labels Aug 14, 2026
@matejvasek
matejvasek requested a review from gauron99 August 14, 2026 18:26
@gauron99

gauron99 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

you have conflicts here, otherwise looks good

@knative-prow-robot knative-prow-robot added the needs-rebase Cannot be merged due to conflicts with HEAD. label Aug 14, 2026
@pmeida
feat: add replica count to func list output
241bde5 
func list showed no replica information, making it impossible
to tell at a glance how many instances of a function were
running without reaching for kubectl.

Adds a Replicas field to ListItem populated by each deployer
backend: k8s reads deployment.Status.ReadyReplicas, keda fetches
the backing Deployment and does the same, and knative reads
ActualReplicas from the latest ready Revision. The REPLICAS
column is added to the plain text output. Integration tests
assert that a deployed function reports at least one replica.
@pmeida
pmeida force-pushed the feat/func-list-replica-count branch from 20af44d to 241bde5 Compare August 17, 2026 09:54
@knative-prow-robot knative-prow-robot removed the needs-rebase Cannot be merged due to conflicts with HEAD. label Aug 17, 2026
@pmeida
pmeida marked this pull request as ready for review August 17, 2026 10:01
@knative-prow knative-prow Bot removed the do-not-merge/work-in-progress 🤖 PR should not merge because it is a work in progress. label Aug 17, 2026
@pmeida

pmeida commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

you have conflicts here, otherwise looks good

it was still a draft, now its not anymore. Also rebased it.
@gauron99 can you please have another look?

gauron99
gauron99 approved these changes Aug 19, 2026
View reviewed changes

@gauron99 gauron99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Aug 19, 2026
@knative-prow

knative-prow Bot commented Aug 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, pmeida

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved 🤖 PR has been approved by an approver from all required OWNERS files. label Aug 19, 2026
@knative-prow
knative-prow Bot merged commit 37eccea into knative:main Aug 19, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gauron99 gauron99 gauron99 approved these changes
@dsimansk dsimansk Awaiting requested review from dsimansk
@jrangelramos jrangelramos Awaiting requested review from jrangelramos

Assignees

@gauron99 gauron99

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. kind/enhancement Feature additions or improvements to existing lgtm 🤖 PR is ready to be merged. needs-ok-to-test 🤖 Needs an org member to approve testing size/M 🤖 PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

func list should show replica count

3 participants

@pmeida @gauron99 @knative-prow-robot